paul/picpeak
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(gallery): publish dialog stuck for password-protected galleries with no inline email

Browse Source 
handleSubmit required a password whenever requirePassword was true, but the
password field only renders on the inline-email path (requirePassword &&
customerEmail). For a password-protected gallery with no inline email the field
was hidden, so submit blocked on the missing password and the dialog never
closed. Gate password collection + validation on a single `needsPassword`
(requirePassword && customerEmail); the no-inline-email path publishes without
re-entering the password (existing hash kept, customer reaches it via portal).
This commit is contained in:
Luca
2026-06-26 15:28:58 +02:00
parent c657892bc8
commit aa3471efe1
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/components/admin/PublishGalleryDialog.tsx
+8 -3
View File
@@ -39,19 +39,24 @@ export const PublishGalleryDialog: React.FC<PublishGalleryDialogProps> = ({
// Someone gets notified if there's an inline email OR an assigned account // Someone gets notified if there's an inline email OR an assigned account
// (the latter via the account "your galleries" email). // (the latter via the account "your galleries" email).
const willNotify = !!customerEmail || assignedCustomerCount > 0; const willNotify = !!customerEmail || assignedCustomerCount > 0;
// The password is only collected (and required) on the inline-email path,
// because the gallery_created email carries it. With no inline email the field
// is hidden and the existing hash is kept — so don't gate submit on it, or a
// password-protected gallery without an email could never be published.
const needsPassword = requirePassword && !!customerEmail;
const [password, setPassword] = useState(''); const [password, setPassword] = useState('');
const [showPassword, setShowPassword] = useState(false); const [showPassword, setShowPassword] = useState(false);
const [error, setError] = useState<string | undefined>(undefined); const [error, setError] = useState<string | undefined>(undefined);
const handleSubmit = () => { const handleSubmit = () => {
if (requirePassword) { if (needsPassword) {
if (!password || password.trim().length < 6) { if (!password || password.trim().length < 6) {
setError(t('events.publishDialog.errorMinLength', 'Password must be at least 6 characters long.')); setError(t('events.publishDialog.errorMinLength', 'Password must be at least 6 characters long.'));
return; return;
} }
} }
setError(undefined); setError(undefined);
onConfirm(requirePassword ? password : undefined); onConfirm(needsPassword ? password : undefined);
}; };
return ( return (
@@ -92,7 +97,7 @@ export const PublishGalleryDialog: React.FC<PublishGalleryDialogProps> = ({
})} })}
</p> </p>
{requirePassword && customerEmail && ( {needsPassword && (
<div className="space-y-3 mb-4"> <div className="space-y-3 mb-4">
<Input <Input
type={showPassword ? 'text' : 'password'} type={showPassword ? 'text' : 'password'}