Files

T

Paul Nothaft ef1c875f6e fix(events): stop mapping branding_logo_position onto hero_logo_position

Two settings with overlapping names but different value sets were being
conflated:

- branding_logo_position (header bar, horizontal): 'left'|'center'|'right'
- hero_logo_position    (hero block, vertical):   'top'|'center'|'bottom'

getBrandingDefaults() copied the global branding value over the per-event
hero value when seeding new events. Any admin with branding logo set to
'left' (the most common choice) created events with hero_logo_position
= 'left' written to the DB. Subsequent PUTs to /admin/events/:id then
failed validation with "Invalid value (field: hero_logo_position)" — the
validator only accepts top/center/bottom.

Fix:

1. Drop the bogus mapping. branding_logo_position is no longer read by
   getBrandingDefaults — it doesn't belong there. The fallback default
   ('top') is used unless the request body explicitly provides
   hero_logo_position, which is independently validated.

2. Migration 084_fix_hero_logo_position normalises any existing rows
   whose hero_logo_position is outside ('top','center','bottom') back
   to 'top'. Without this, affected events would continue to 400 on
   every save until the admin manually picks a valid option.

Reproduction: admin sets branding logo position to 'left' under global
branding, creates an event, opens the event detail page, clicks Save
without changing anything → 400. After this fix, save succeeds and new
events default to 'top' regardless of branding-bar position.

2026-05-02 00:04:06 +02:00

core

fix(events): stop mapping branding_logo_position onto hero_logo_position

2026-05-02 00:04:06 +02:00

legacy

fix: prevent database migration restart failures

2026-01-15 15:43:13 +01:00

041_add_logo_customization_settings.js

feat: implement gallery logo customization (Issue #17 )

2025-09-05 14:56:09 +02:00

helpers.js

Initial commit - Project start (July 17, 2025)

2025-07-24 16:57:07 +02:00

README.md

feat: pre-generate watermarks for instant lightbox loading

2026-01-15 21:00:10 +01:00

run-migrations-safe.js

fix: prevent database migration restart failures

2026-01-15 15:43:13 +01:00

run-migrations.js

fix: prevent database migration restart failures

2026-01-15 15:43:13 +01:00

README.md

Database Migrations

This directory contains database migrations for the PicPeak photo sharing platform.

Directory Structure

`/core`

Essential migrations that are always run for new deployments. These include:

init.js - Initial database schema creation
Backup service tables (029-035)
Gallery feedback tables (033)
Pre-generated watermarks (061)

`/legacy`

Migrations needed only when upgrading from older versions. New deployments can skip these as the core schema already includes all necessary tables and columns.

For New Deployments

If you're deploying this application for the first time:

The initializeDatabase() function in src/database/db.js will create all necessary tables
Only migrations in the /core directory will be run
This ensures a clean, optimized database schema

For Existing Deployments

If you're upgrading from an older version:

All migrations (both core and legacy) will be run in sequence
The migration system tracks which migrations have been applied
Only new migrations will be executed

Running Migrations

# Development
npm run migrate

# Production
npm run migrate:prod

Note on Duplicate Migration Numbers

The legacy directory contains renamed duplicates:

014_add_host_name_to_events_duplicate.js (was duplicate of 014)
027_add_rate_limit_settings_duplicate.js (was duplicate of 027)

These have been renamed to avoid conflicts while preserving the migration history.