Paul Nothaft
d868aac703
* fix(security): close the 5 open Trivy alerts — dep bumps + drop npm from the runtime image Backend deps: - postcss 8.5.10 -> 8.5.18 (CVE-2026-45623, GHSA-r28c-9q8g-f849; the pin exists to force sanitize-html's transitive copy onto a fixed version) - tar pin/override >=7.5.16 -> >=7.5.21, resolves 7.5.22 (GHSA-r292-9mhp-454m) Runtime image: - Remove the npm CLI from the final stage instead of upgrading it: npm's bundled node_modules ship tar 7.5.19 and brace-expansion 5.0.7 (no npm release bundles the fixed versions — checked 11.18.0 and 12.0.1), and npm never runs in production. wait-for-db.sh now invokes the migration runners via node directly. This ends the recurring npm-bundled-CVE alert class; the previous 'npm install -g npm@11' line was itself a patch for the last batch. (stable) * fix(restore): run post-restore migrations via node — the image ships no npm restoreService still shelled out to 'npm run migrate:safe' after a restore; with npm removed from the runtime image that would ENOENT into the non-fatal catch, silently leaving a restored older backup on a schema behind the running code until the next container restart. Invoke migrations/run-migrations-safe.js through node directly, matching wait-for-db.sh. The PR #596 source-contract test now pins the new invocation. (stable)
113 lines
5.2 KiB
Docker
113 lines
5.2 KiB
Docker
FROM node:22-alpine AS builder
|
|
|
|
# Add build arguments
|
|
ARG CACHEBUST=1
|
|
ARG BUILD_DATE
|
|
ARG VCS_REF
|
|
ARG VERSION
|
|
|
|
# Add labels for GitHub Container Registry
|
|
LABEL org.opencontainers.image.source="https://github.com/PicPeak/picpeak"
|
|
LABEL org.opencontainers.image.description="PicPeak Backend Service"
|
|
LABEL org.opencontainers.image.licenses="MIT"
|
|
|
|
WORKDIR /app
|
|
|
|
# Copy package files
|
|
COPY package*.json ./
|
|
|
|
# Install dependencies (--omit=dev replaces deprecated --only=production)
|
|
RUN npm ci --omit=dev
|
|
|
|
# Copy application files
|
|
COPY . .
|
|
|
|
# Production stage
|
|
FROM node:22-alpine
|
|
|
|
WORKDIR /app
|
|
|
|
# Redeclare CACHEBUST — ARGs don't cross stage boundaries, so the builder
|
|
# stage's declaration never reached this stage. Consuming it in the RUN below
|
|
# busts that layer's cache every CI run (CACHEBUST=github.run_number), so the
|
|
# image always picks up current Alpine security updates instead of reusing a
|
|
# stale cached upgrade layer.
|
|
ARG CACHEBUST=1
|
|
|
|
# Upgrade all packages to fix security vulnerabilities (OpenSSL, libexpat, BusyBox CVEs)
|
|
RUN echo "cachebust=${CACHEBUST}" && apk upgrade --no-cache
|
|
|
|
# Remove the npm CLI from the final image. Nothing runs npm here: the
|
|
# entrypoint is node, runtime deps are COPY'd from the builder stage, and
|
|
# wait-for-db.sh invokes the migration runners via node directly. npm's
|
|
# bundled node_modules kept tripping Trivy (sigstore, tar 7.5.19,
|
|
# brace-expansion 5.0.7 — even npm 12.0.1 still ships the vulnerable
|
|
# copies), so shipping no npm ends that alert class instead of chasing
|
|
# per-release patches. Note: `docker exec … npm run <script>` no longer
|
|
# works in the container — use `node migrations/run-migrations-safe.js`
|
|
# and friends instead.
|
|
RUN rm -rf /usr/local/lib/node_modules/npm /usr/local/bin/npm /usr/local/bin/npx
|
|
|
|
# Install dumb-init for proper signal handling, postgresql-client for database
|
|
# checks, ffmpeg for video upload support, and su-exec for the root → nodejs
|
|
# privilege drop in wait-for-db.sh (see #484: container starts as root so it
|
|
# can chown bind-mounted host volumes to UID 1001, then re-execs as nodejs
|
|
# before running the app). Alpine's ffmpeg package ships both `ffmpeg` and
|
|
# `ffprobe` built natively against musl libc — the npm
|
|
# `@ffmpeg-installer/ffmpeg` binary is glibc-built and (a) doesn't reliably
|
|
# run on Alpine and (b) only includes ffmpeg, not ffprobe (which the video
|
|
# pipeline calls via fluent-ffmpeg.ffprobe()).
|
|
# fontconfig is required so `sharp` (librsvg) can rasterise SVG logos that
|
|
# contain live <text> for the CRM PDFs. Without any font installed, librsvg
|
|
# renders text as tofu boxes (□) while the vector artwork still draws — i.e.
|
|
# a "corrupted" logo on invoices/quotes. DejaVu/Liberation provide a broad
|
|
# Unicode fallback; picpeak's own brand fonts (assets/fonts/, the same files
|
|
# PDFKit + the web UI use) are registered with fontconfig further down so the
|
|
# logo's text renders in its actual typeface, not a fallback.
|
|
# poppler-utils provides `pdftoppm`, used to rasterise inbound supplier-invoice
|
|
# PDFs to flat PNGs server-side so the admin UI NEVER renders a raw (possibly
|
|
# malicious) PDF. pdftoppm does not execute embedded JS or fetch remote
|
|
# resources, so it doubles as the SSRF/phone-home guard for untrusted inbound
|
|
# documents (see docs/accounting-inbound-invoices.md).
|
|
RUN apk add --no-cache dumb-init postgresql-client ffmpeg su-exec \
|
|
fontconfig ttf-dejavu ttf-liberation poppler-utils && \
|
|
fc-cache -f
|
|
|
|
# Create non-root user
|
|
RUN addgroup -g 1001 -S nodejs && adduser -S nodejs -u 1001
|
|
|
|
# Copy from builder
|
|
COPY --from=builder --chown=nodejs:nodejs /app/node_modules ./node_modules
|
|
COPY --chown=nodejs:nodejs . .
|
|
|
|
# Ensure all source files are readable and wait script is executable
|
|
RUN chmod -R a+r /app && chmod +x wait-for-db.sh
|
|
|
|
# Register picpeak's bundled brand fonts (assets/fonts/<Family>/*.ttf — the
|
|
# same files PDFKit and the web UI use) with fontconfig, so when sharp/librsvg
|
|
# rasterises an SVG logo its <text> renders in the actual brand typeface
|
|
# rather than a DejaVu/Liberation fallback. fontconfig indexes by each font's
|
|
# internal family name and recurses into the per-family subdirectories.
|
|
RUN printf '<?xml version="1.0"?>\n<!DOCTYPE fontconfig SYSTEM "fonts.dtd">\n<fontconfig>\n <dir>/app/assets/fonts</dir>\n</fontconfig>\n' > /etc/fonts/conf.d/99-picpeak-fonts.conf && \
|
|
fc-cache -f /app/assets/fonts
|
|
|
|
# Create necessary directories
|
|
RUN mkdir -p storage/events/active storage/events/archived storage/thumbnails data logs && \
|
|
chown -R nodejs:nodejs storage data logs
|
|
|
|
# No USER directive — the container starts as root so wait-for-db.sh can
|
|
# chown bind-mounted host directories to UID 1001 before dropping privs
|
|
# via su-exec. See #484 for the fresh-install restart loop this avoids.
|
|
|
|
EXPOSE 3000
|
|
|
|
# Healthcheck hits the same /health endpoint already used by the e2e
|
|
# runner and by the docker-compose `depends_on: condition: service_healthy`
|
|
# checks. wget is part of the Alpine base image. Long start-period covers
|
|
# the wait-for-db.sh delay before the Node process starts listening.
|
|
HEALTHCHECK --interval=30s --timeout=5s --start-period=60s --retries=3 \
|
|
CMD wget --no-verbose --tries=1 --spider http://localhost:3000/health || exit 1
|
|
|
|
ENTRYPOINT ["dumb-init", "--"]
|
|
CMD ["./wait-for-db.sh", "node", "server.js"]
|