Turning on maintenance mode locked out every admin — including ones already logged in — with no way back in from the browser. Two causes: 1. Backend (middleware/maintenance.js): the skipPaths allow-list pointed at /api/admin/login and /api/admin/auth/login, but the real admin auth routes live under /api/auth (POST /api/auth/admin/login, GET /api/auth/session). So during maintenance both the login POST and the session check 503'd. The 503 on /auth/session made the frontend read every admin as logged-out, and also tripped the axios interceptor that force-enables maintenance globally. Fixed the allow-list to the actual endpoints. 2. Frontend (MaintenanceWrapper.tsx): the maintenance screen rendered over every /admin/* route unless an admin session already existed — covering the /admin/login page itself. A logged-out admin could never reach the form to get a session (catch-22). /admin/login is now always allowed through. With both: a logged-in admin keeps working (session check passes), and a logged-out admin can reach /admin/login and sign back in, all while maintenance mode correctly blocks customers.
116 lines
3.7 KiB
JavaScript
116 lines
3.7 KiB
JavaScript
const { db } = require('../database/db');
|
|
|
|
// Cache maintenance mode status to avoid DB queries on every request
|
|
let maintenanceMode = false;
|
|
let lastCheck = 0;
|
|
const CACHE_DURATION = 60000; // 1 minute
|
|
|
|
// Retry configuration for database queries
|
|
const MAX_RETRIES = 3;
|
|
const RETRY_DELAY = 1000; // 1 second
|
|
|
|
async function queryWithRetry(queryFn, retries = MAX_RETRIES) {
|
|
for (let i = 0; i < retries; i++) {
|
|
try {
|
|
return await queryFn();
|
|
} catch (error) {
|
|
if (i === retries - 1) {
|
|
throw error;
|
|
}
|
|
|
|
// Check if it's a connection error that might benefit from retry
|
|
const isConnectionError =
|
|
error.message?.includes('Connection terminated') ||
|
|
error.message?.includes('ECONNREFUSED') ||
|
|
error.message?.includes('ETIMEDOUT') ||
|
|
error.code === 'ECONNRESET';
|
|
|
|
if (isConnectionError) {
|
|
console.warn(`Database connection error, retrying in ${RETRY_DELAY}ms... (attempt ${i + 1}/${retries})`);
|
|
await new Promise(resolve => setTimeout(resolve, RETRY_DELAY));
|
|
} else {
|
|
throw error; // Don't retry non-connection errors
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
async function checkMaintenanceMode() {
|
|
const now = Date.now();
|
|
|
|
// Use cached value if recent
|
|
if (now - lastCheck < CACHE_DURATION) {
|
|
return maintenanceMode;
|
|
}
|
|
|
|
try {
|
|
const setting = await queryWithRetry(async () => {
|
|
return await db('app_settings')
|
|
.where('setting_key', 'general_maintenance_mode')
|
|
.where('setting_type', 'general')
|
|
.first();
|
|
});
|
|
|
|
maintenanceMode = setting ? (setting.setting_value === 'true' || setting.setting_value === true) : false;
|
|
lastCheck = now;
|
|
|
|
return maintenanceMode;
|
|
} catch (error) {
|
|
console.error('Error checking maintenance mode after retries:', error.message);
|
|
// Return cached value or false if no cache
|
|
return maintenanceMode;
|
|
}
|
|
}
|
|
|
|
// Middleware to enforce maintenance mode
|
|
async function maintenanceMiddleware(req, res, next) {
|
|
// Skip maintenance check for certain paths. Admin auth MUST work during
|
|
// maintenance — otherwise enabling it locks every admin out, including
|
|
// already-logged-in ones (their /auth/session check would 503 and read as
|
|
// logged-out). These are the REAL endpoints: the admin login + session
|
|
// routes live under /api/auth, NOT /api/admin (the old /api/admin/login
|
|
// entries here matched nothing, which is exactly why the lockout happened).
|
|
const skipPaths = [
|
|
'/api/auth/admin/login',
|
|
'/api/auth/session',
|
|
'/api/public/settings',
|
|
'/health'
|
|
];
|
|
|
|
// Allow static assets (uploads, favicons, logos)
|
|
const isStaticAsset = req.path.startsWith('/uploads/') ||
|
|
req.path.startsWith('/favicons/') ||
|
|
req.path.startsWith('/logos/');
|
|
|
|
// Allow admin routes if admin is authenticated
|
|
const isAdminRoute = req.path.startsWith('/api/admin');
|
|
const hasAdminAuth = req.headers.authorization?.startsWith('Bearer ');
|
|
|
|
if (skipPaths.includes(req.path) || isStaticAsset || (isAdminRoute && hasAdminAuth)) {
|
|
return next();
|
|
}
|
|
|
|
try {
|
|
const inMaintenance = await checkMaintenanceMode();
|
|
|
|
if (inMaintenance && !isAdminRoute) {
|
|
return res.status(503).json({
|
|
error: 'Service Unavailable',
|
|
message: 'The system is currently undergoing maintenance. Please try again later.',
|
|
maintenance: true
|
|
});
|
|
}
|
|
} catch (error) {
|
|
// If we can't check maintenance mode, allow the request to proceed
|
|
console.error('Failed to check maintenance mode, allowing request:', error.message);
|
|
}
|
|
|
|
next();
|
|
}
|
|
|
|
// Function to clear cache when settings change
|
|
function clearMaintenanceCache() {
|
|
lastCheck = 0;
|
|
}
|
|
|
|
module.exports = { maintenanceMiddleware, clearMaintenanceCache }; |