paul/picpeak
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Merge pull request #679 from Luca-Timo/feat/booking-cutover

Browse Source 
feat(workflows): booking cutover — wire booking actions + hold documents behind approval gates
This commit is contained in:
Paul Nothaft
2026-06-28 21:53:09 +02:00
committed by GitHub
parent e6f29b6345 6e20d58487
commit ec33ec7670
15 changed files with 665 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/i18n/locales/de.json
+1
View File
@@ -238,6 +238,7 @@
"defaultPrompt": "Ein Workflow benötigt deine Bestätigung.",
"pendingTitle": "Offene Freigaben",
"viewAll": "Alle Freigaben ansehen",
"openEntity": "{{type}} #{{id}} öffnen",
"acted": "Erledigt"
},
"editor": {
frontend/src/i18n/locales/en.json
+1
View File
@@ -238,6 +238,7 @@
"defaultPrompt": "A workflow needs your confirmation.",
"pendingTitle": "Pending approvals",
"viewAll": "View all approvals",
"openEntity": "Open {{type}} #{{id}}",
"acted": "Done"
},
"editor": {
frontend/src/pages/admin/AdminDashboard.tsx
+32 -6
View File
@@ -96,6 +96,17 @@ export const AdminDashboard: React.FC = () => {
onError: (err: any) => toast.error(err?.response?.data?.error || (t('common.error', 'Something went wrong') as string)),
});
// Admin detail route for an approval's run entity, so clicking opens the
// document under review. Mirrors WorkflowApprovalsPage (`invoice` → /bills).
const approvalEntityHref = (a: { entity_type?: string | null; entity_id?: number | null }): string | null => {
if (!a.entity_type || a.entity_id == null) return null;
const base: Record<string, string> = {
quote: 'quotes', invoice: 'bills', event: 'events', contract: 'contracts', customer: 'customers',
};
const seg = base[a.entity_type];
return seg ? `/admin/${seg}/${a.entity_id}` : null;
};
const isLoading = statsLoading || eventsLoading;
if (isLoading) {
@@ -277,14 +288,29 @@ export const AdminDashboard: React.FC = () => {
<div className="space-y-3">
{pendingApprovals.slice(0, 5).map((a) => {
const prompt = (a.payload as any)?.prompt as string | undefined;
const href = approvalEntityHref(a);
const info = (
<>
<h3 className="font-medium text-neutral-900 dark:text-neutral-100 truncate">{a.workflow_name}</h3>
<p className="text-sm text-neutral-600 dark:text-neutral-400 truncate">
{prompt || a.type}{a.entity_type ? ` · ${a.entity_type} #${a.entity_id}` : ''}
</p>
</>
);
return (
<div key={a.id} className="flex items-center justify-between gap-3 p-4 bg-purple-50 dark:bg-purple-900/20 rounded-lg border border-purple-200 dark:border-purple-800">
<div className="min-w-0">
<h3 className="font-medium text-neutral-900 dark:text-neutral-100 truncate">{a.workflow_name}</h3>
<p className="text-sm text-neutral-600 dark:text-neutral-400 truncate">
{prompt || a.type}{a.entity_type ? ` · ${a.entity_type} #${a.entity_id}` : ''}
</p>
</div>
{href ? (
<button
type="button"
onClick={() => navigate(href)}
className="min-w-0 text-left rounded -m-1 p-1 hover:bg-purple-100/60 dark:hover:bg-purple-900/40 transition-colors cursor-pointer"
title={t('workflows.approvals.openEntity', 'Open {{type}} #{{id}}', { type: a.entity_type, id: a.entity_id }) as string}
>
{info}
</button>
) : (
<div className="min-w-0">{info}</div>
)}
<div className="flex items-center gap-2 shrink-0">
<Button variant="primary" size="sm" isLoading={approvalMutation.isPending}
onClick={() => approvalMutation.mutate({ id: a.id, action: 'confirm' })}
frontend/src/pages/admin/workflows/WorkflowApprovalsPage.tsx
+40 -12
View File
@@ -36,6 +36,17 @@ export const WorkflowApprovalsPage: React.FC = () => {
const promptOf = (a: WorkflowApproval) => (a.payload && (a.payload.prompt as string)) || t('workflows.approvals.defaultPrompt', 'A workflow needs your confirmation.');
// The admin detail route for the run's entity, so a row click opens the
// document they're being asked to approve. `invoice` lives under /bills.
const entityHref = (a: WorkflowApproval): string | null => {
if (!a.entity_type || a.entity_id == null) return null;
const base: Record<string, string> = {
quote: 'quotes', invoice: 'bills', event: 'events', contract: 'contracts', customer: 'customers',
};
const seg = base[a.entity_type];
return seg ? `/admin/${seg}/${a.entity_id}` : null;
};
return (
<div className="space-y-6">
<div className="flex items-center gap-3">
@@ -55,24 +66,41 @@ export const WorkflowApprovalsPage: React.FC = () => {
<div className="p-10 text-center text-neutral-500 dark:text-neutral-400">{t('workflows.approvals.empty', 'Nothing waiting for you right now.')}</div>
) : (
<ul className="divide-y divide-neutral-200 dark:divide-neutral-700">
{approvals.map((a) => (
<li key={a.id} className="flex items-center gap-3 px-4 py-3">
<div className="min-w-0 flex-1">
{approvals.map((a) => {
const href = entityHref(a);
const meta = (
<>
<div className="text-sm text-neutral-900 dark:text-neutral-100">{promptOf(a)}</div>
<div className="text-xs text-neutral-500 dark:text-neutral-400 mt-0.5">
{a.workflow_name}
{a.entity_type ? ` · ${a.entity_type} #${a.entity_id}` : ''}
{a.created_at ? ` · ${formatDateTime(a.created_at)}` : ''}
</div>
</div>
<Button variant="outline" size="sm" isLoading={actMutation.isPending} onClick={() => actMutation.mutate({ id: a.id, action: 'confirm' })} leftIcon={<Check className="w-4 h-4" />}>
{t('workflows.approvals.confirm', 'Confirm')}
</Button>
<Button variant="ghost" size="sm" onClick={() => actMutation.mutate({ id: a.id, action: 'deny' })} leftIcon={<X className="w-4 h-4" />}>
{t('workflows.approvals.deny', 'Deny')}
</Button>
</li>
))}
</>
);
return (
<li key={a.id} className="flex items-center gap-3 px-4 py-3">
{href ? (
<button
type="button"
onClick={() => navigate(href)}
className="min-w-0 flex-1 text-left rounded -mx-1 px-1 py-0.5 hover:bg-neutral-50 dark:hover:bg-neutral-800/60 transition-colors cursor-pointer"
title={t('workflows.approvals.openEntity', 'Open {{type}} #{{id}}', { type: a.entity_type, id: a.entity_id }) as string}
>
{meta}
</button>
) : (
<div className="min-w-0 flex-1">{meta}</div>
)}
<Button variant="outline" size="sm" isLoading={actMutation.isPending} onClick={() => actMutation.mutate({ id: a.id, action: 'confirm' })} leftIcon={<Check className="w-4 h-4" />}>
{t('workflows.approvals.confirm', 'Confirm')}
</Button>
<Button variant="ghost" size="sm" onClick={() => actMutation.mutate({ id: a.id, action: 'deny' })} leftIcon={<X className="w-4 h-4" />}>
{t('workflows.approvals.deny', 'Deny')}
</Button>
</li>
);
})}
</ul>
)}
</Card>