paul/picpeak
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(gallery): admin edits to welcome_message land for returning guests (#625)

Browse Source 
GalleryAuthContext cached the event in sessionStorage on first visit and
then SKIPPED the server fetch on returning visits (`if (!storedEvent)`),
so a guest who'd already opened the gallery would never see admin edits
to welcome_message / event_name / hero_logo / colour theme — sessionStorage
survives Cmd+Shift+R, so the only escape was closing the tab or wiping
site data manually.

The cached event is still shown above as an instant placeholder for
perceived perf, but the server fetch is no longer gated: on every mount
the fresh row overwrites both React state and the sessionStorage entry.
Cost is one extra /gallery/:slug/photos request per gallery navigation
when the session is already authenticated; benefit is admin edits
propagating on next page load for everyone.
This commit is contained in:
Paul Nothaft
2026-06-17 22:47:48 +02:00
parent 178d6dafb1
commit ea6245cfde
1 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/contexts/GalleryAuthContext.tsx
+13 -8
View File
@@ -212,14 +212,19 @@ export const GalleryAuthProvider: React.FC<GalleryAuthProviderProps> = ({ childr
if (sessionResponse.data?.valid && sessionResponse.data.type === 'gallery' && sessionResponse.data.eventSlug === currentSlug) { if (sessionResponse.data?.valid && sessionResponse.data.type === 'gallery' && sessionResponse.data.eventSlug === currentSlug) {
setIsAuthenticated(true); setIsAuthenticated(true);
if (!storedEvent) { // Always refresh from the server — the stored event from sessionStorage
const galleryData = await galleryService.getGalleryPhotos(currentSlug); // is shown above as an instant placeholder for perceived perf, but it
if (galleryData?.event) { // must NOT win permanently: admin edits to welcome_message / event_name /
const normalizedEvent = normalizeEvent(galleryData.event); // hero_logo / colour theme need to land on the next page load for
setEvent(normalizedEvent); // returning guests. sessionStorage survives Cmd+Shift+R, so without
if (normalizedEvent) { // this refresh the cache could only be cleared by closing the tab or
sessionStorage.setItem(`gallery_event_${currentSlug}`, JSON.stringify(normalizedEvent)); // wiping site data manually (#625).
} const galleryData = await galleryService.getGalleryPhotos(currentSlug);
if (galleryData?.event) {
const normalizedEvent = normalizeEvent(galleryData.event);
setEvent(normalizedEvent);
if (normalizedEvent) {
sessionStorage.setItem(`gallery_event_${currentSlug}`, JSON.stringify(normalizedEvent));
} }
} }