paul/picpeak
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(uploads): DNG magic must be a single entry (.every validation)

Browse Source 
The magic-number check in validateFileContent uses .every(), so the two
endianness entries (II + MM) could never both match — an admin DNG upload would
be rejected at content validation. Use the little-endian II magic only (Apple
ProRAW / camera DNGs); a rare big-endian DNG fails the check and is rejected,
which is safe since the embedded-preview extraction validates real content.
This commit is contained in:
Paul Nothaft
2026-07-17 22:07:32 +02:00
parent be2ec0a4a1
commit e732e13f24
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/utils/fileSecurityUtils.js
+6 -2
View File
@@ -88,9 +88,13 @@ const ALLOWED_IMAGE_TYPES = {
// DNG MIME (Chrome does; browsers that send an empty type won't get this far). // DNG MIME (Chrome does; browsers that send an empty type won't get this far).
'image/x-adobe-dng': { 'image/x-adobe-dng': {
extensions: ['.dng'], extensions: ['.dng'],
// Single entry: the magic check is `.every`, so listing both endianness
// variants would require BOTH to match (impossible). DNG is TIFF; Apple
// ProRAW and virtually all camera DNGs are little-endian ("II*\0"). A rare
// big-endian DNG would fail this check and be rejected — acceptable, since
// the embedded-preview extraction validates the real content downstream.
magicNumbers: [ magicNumbers: [
{ offset: 0, bytes: [0x49, 0x49, 0x2A, 0x00] }, // little-endian TIFF (II*\0) { offset: 0, bytes: [0x49, 0x49, 0x2A, 0x00] } // little-endian TIFF (II*\0)
{ offset: 0, bytes: [0x4D, 0x4D, 0x00, 0x2A] } // big-endian TIFF (MM\0*)
] ]
} }
}; };