paul/picpeak
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(email): IMAP Security dropdown matches outgoing — no port in label, manual port

Browse Source 
Reverts the auto-fill; drops the (993)/(143) from the Security option labels so
incoming behaves exactly like the outgoing SMTP card (plain SSL/TLS vs
STARTTLS, port set manually).
This commit is contained in:
Luca
2026-06-12 14:41:49 +02:00
parent bd402d2e89
commit d04a6978e9
3 changed files with 7 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/components/admin/IncomingMailConfigCard.tsx
+3 -17
View File
@@ -30,20 +30,6 @@ export const IncomingMailConfigCard: React.FC = () => {
const set = (k: keyof IncomingMailConfig, v: any) => setCfg((c) => ({ ...c, [k]: v }));
// Changing Security auto-fills the conventional IMAP port (SSL/TLS → 993,
// STARTTLS/none → 143) so the port in the dropdown label isn't just
// decoration. A non-standard custom port is left untouched.
const onSecurityChange = (val: string) => {
const secure = val === 'ssl';
setCfg((c) => {
const next = { ...c, imap_secure: secure };
if (!c.imap_port || c.imap_port === 993 || c.imap_port === 143) {
next.imap_port = secure ? 993 : 143;
}
return next;
});
};
const save = useMutation({
mutationFn: () => {
// Mirror the SMTP card's client-side required guard. Host + port +
@@ -105,9 +91,9 @@ export const IncomingMailConfigCard: React.FC = () => {
</div>
<div>
<label className={labelCls}>{t('email.incoming.security', 'Security')}</label>
<select className={selectCls} value={cfg.imap_secure ? 'ssl' : 'plain'} onChange={(e) => onSecurityChange(e.target.value)}>
<option value="ssl">{t('email.incoming.ssl', 'SSL/TLS (993)')}</option>
<option value="plain">{t('email.incoming.plain', 'None / STARTTLS (143)')}</option>
<select className={selectCls} value={cfg.imap_secure ? 'ssl' : 'plain'} onChange={(e) => set('imap_secure', e.target.value === 'ssl')}>
<option value="ssl">{t('email.incoming.ssl', 'SSL/TLS')}</option>
<option value="plain">{t('email.incoming.plain', 'None / STARTTLS')}</option>
</select>
</div>
</div>