paul/picpeak
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(reminders): wrap is_active/is_archived wheres in formatBoolean

Browse Source 
eventReminderService used bare boolean literals in its knex .where() calls
(events.is_active/is_archived/event_reminder_disabled and the assigned-
customer c.is_active), instead of the codebase's formatBoolean() convention
(utils/dbCompat). On SQLite, booleans are stored as 0/1, so a bare `true`
relies on knex's coercion rather than the explicit helper every other service
uses — the maintainer flagged this twice (#674, #679). Wrap all four.
This commit is contained in:
Luca
2026-06-29 19:39:40 +02:00
parent 06f4c109bc
commit b9d91385b4
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/eventReminderService.js
+5 -4
View File
@@ -55,6 +55,7 @@
const { db } = require('../database/db'); const { db } = require('../database/db');
const emailProcessor = require('./emailProcessor'); const emailProcessor = require('./emailProcessor');
const { formatBoolean } = require('../utils/dbCompat');
const { getAppSetting } = require('../utils/appSettings'); const { getAppSetting } = require('../utils/appSettings');
const { hasColumnCached } = require('../utils/schemaCache'); const { hasColumnCached } = require('../utils/schemaCache');
const logger = require('../utils/logger'); const logger = require('../utils/logger');
@@ -176,9 +177,9 @@ async function runEventReminderPass() {
const now = new Date(); const now = new Date();
const rows = await db('events') const rows = await db('events')
.whereNotNull('events.event_date') .whereNotNull('events.event_date')
.where('events.is_active', true) .where('events.is_active', formatBoolean(true))
.where('events.is_archived', false) .where('events.is_archived', formatBoolean(false))
.where('events.event_reminder_disabled', false) .where('events.event_reminder_disabled', formatBoolean(false))
.whereNull('events.event_reminder_sent_at') .whereNull('events.event_reminder_sent_at')
.where('events.event_date', '>=', now.toISOString().slice(0, 10)) .where('events.event_date', '>=', now.toISOString().slice(0, 10))
.select('events.*'); .select('events.*');
@@ -328,7 +329,7 @@ async function resolveReminderRecipients(eventRow) {
const assigned = await db('event_customer_assignments as a') const assigned = await db('event_customer_assignments as a')
.join('customer_accounts as c', 'c.id', 'a.customer_account_id') .join('customer_accounts as c', 'c.id', 'a.customer_account_id')
.where('a.event_id', eventRow.id) .where('a.event_id', eventRow.id)
.where('c.is_active', true) .where('c.is_active', formatBoolean(true))
.whereNotNull('c.email') .whereNotNull('c.email')
.select('c.email'); .select('c.email');
// De-dup emails defensively (a customer assigned twice, etc.). // De-dup emails defensively (a customer assigned twice, etc.).