paul/picpeak
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(customer): don't log customer out on transient session-refresh errors

Browse Source
This commit is contained in:
Luca
2026-05-12 00:07:50 +02:00
parent d0ad9879bd
commit 9e418c759c
2 changed files with 55 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/contexts/CustomerAuthContext.tsx
+30 -15
View File
@@ -84,22 +84,37 @@ export const CustomerAuthProvider: React.FC<ProviderProps> = ({ children }) => {
* mount-time sessionStorage cache and stays stale until a hard reload.
*/
const refreshSession = React.useCallback(async () => {
// Contract (see customerService.session()):
// - object → fresh data, store it.
// - null → server says we're explicitly logged out (401);
// clear local state.
// - throw → transient error (network blip, 5xx, timeout).
// KEEP whatever state we have — logging the user out
// on a flaky network call is the wrong default. The
// old code clobbered local state on any error, which
// caused mysterious "customer keeps getting kicked
// out" reports during unrelated admin saves and on
// brief connection drops.
let response: Awaited<ReturnType<typeof customerService.session>>;
try {
const response = await customerService.session();
if (response?.customer) {
setCustomerState(response.customer);
setFeatures(response.features);
setBranding(response.branding);
sessionStorage.setItem(STORAGE_KEY, JSON.stringify(response.customer));
sessionStorage.setItem(FEATURES_KEY, JSON.stringify(response.features));
sessionStorage.setItem(BRANDING_KEY, JSON.stringify(response.branding));
} else {
setCustomerState(null);
sessionStorage.removeItem(STORAGE_KEY);
sessionStorage.removeItem(FEATURES_KEY);
sessionStorage.removeItem(BRANDING_KEY);
}
} catch {
response = await customerService.session();
} catch (err) {
// Transient. Don't touch state. The next focus/visibility tick
// will retry; if the customer really is unauthenticated the
// retry will see the 401 and clear properly.
// eslint-disable-next-line no-console
console.warn('[CustomerAuth] session refresh failed transiently, keeping current state', err);
return;
}
if (response?.customer) {
setCustomerState(response.customer);
setFeatures(response.features);
setBranding(response.branding);
sessionStorage.setItem(STORAGE_KEY, JSON.stringify(response.customer));
sessionStorage.setItem(FEATURES_KEY, JSON.stringify(response.features));
sessionStorage.setItem(BRANDING_KEY, JSON.stringify(response.branding));
} else {
// Explicit 401 — server says no.
setCustomerState(null);
sessionStorage.removeItem(STORAGE_KEY);
sessionStorage.removeItem(FEATURES_KEY);