fix: mirror #734 onto decomposed files (PG NaN slideshow seed, SQLite bool renders)

Same two pre-existing-on-main bugs, at their post-decomposition
locations: clampIntOrUndefined in adminEvents/crud.js slideshow seed;
!! coercion in EventDetailsHeader, EventInformationCard,
ClientAccessCard. Keeps this branch correct in either merge order with
#734 — when merging main afterwards, resolve the adminEvents.js
modify/delete conflict by keeping the deletion.

backend/src/routes/adminEvents/crud.js

@@ -24,6 +24,7 @@ const { normaliseEventTimeTriple } = require('../../services/eventService');
 const { hasColumnCached } = require('../../utils/schemaCache');
 const { requireEventOwnership } = require('../../middleware/ownership');
 const { getAppSetting } = require('../../utils/appSettings');
+const { clampIntOrUndefined } = require('../../utils/numericHelpers');
 const { getFrontendBaseUrl } = require('../../utils/frontendUrl');
 const downloadZipService = require('../../services/downloadZipService');
 const { validateHeroImageAnchor, getEventFieldRequirements, readBooleanSetting, getDownloadProtectionDefaults, getBrandingDefaults, getCustomerNameFromPayload, getCustomerEmailFromPayload, getCustomerPhoneFromPayload, isPhoneFieldEnabled, mapEventForApi, hasCustomerContactColumns, deleteEventCascade, SLIDESHOW_TRANSITIONS, SLIDESHOW_COLORFILTERS } = require('./helpers');
@@ -369,7 +370,13 @@ module.exports = (router) => {
       let slideshowSeed = {};
       if (await hasColumnCached('events', 'show_interval_ms')) {
         try {
-          const intP = (v, min, max) => (Number.isFinite(+v) ? Math.min(max, Math.max(min, parseInt(v, 10))) : undefined);
+          // parseInt-first: the previous `Number.isFinite(+v)` pre-check let
+          // NaN through for null/''/true (+null is 0, parseInt(null) is NaN),
+          // producing show_interval_ms=NaN in the INSERT — PG rejects that
+          // with "invalid input syntax for type integer" while SQLite
+          // silently stores NULL, so event creation 500'd on PG whenever the
+          // slideshow app_settings rows were absent.
+          const intP = (v, min, max) => clampIntOrUndefined(v, min, max);
           const oneOf = (v, allowed) => (allowed.includes(v) ? v : undefined);
           const i = intP(await getAppSetting('slideshow_interval_ms', undefined), 1000, 120000);
           const tr = oneOf(await getAppSetting('slideshow_transition', undefined), SLIDESHOW_TRANSITIONS);

backend/src/utils/numericHelpers.js

@@ -31,4 +31,20 @@ function ensureNumber(value, fallback = 0) {
   return Number.isFinite(n) ? n : fallback;
 }
 
-module.exports = { ensureInt, ensureNumber };
+/**
+ * Parse a value as an integer clamped to [min, max]; `undefined` on
+ * anything that doesn't parse (null, undefined, '', booleans, garbage).
+ *
+ * Exists because the inline guard `Number.isFinite(+v) ? parseInt(v)`
+ * disagrees with itself for null/''/true (`+null` is 0 but
+ * `parseInt(null)` is NaN), which let NaN through Math.min/Math.max
+ * and into an INSERT — PostgreSQL rejects NaN for integer columns
+ * while SQLite silently stores NULL, so it only failed on PG.
+ */
+function clampIntOrUndefined(value, min, max) {
+  const n = parseInt(value, 10);
+  if (!Number.isFinite(n)) return undefined;
+  return Math.min(max, Math.max(min, n));
+}
+
+module.exports = { ensureInt, ensureNumber, clampIntOrUndefined };