From 758dc005df69d15c85eaf0f7a293d82390400765 Mon Sep 17 00:00:00 2001
From: Paul Nothaft <paul@MacStudio-von-Paul.local>
Date: Tue, 1 Sep 2026 19:03:00 +0200
Subject: [PATCH] fix(events): rename a shadowing local and bound the photo-cap
 input

Two small fixes in one file.

The local `mode` at line 323 collided with the info-banner `mode` the i18next
TS resolver reads at line 490, so the extractor emitted four keys the code can
never request (events.infoBanner.mode_managed / mode_reference and the
promoBanner pair) -- the real modes are inherit|custom|off. Renamed to
sourceMode; the four phantom keys are dropped from the locale files.

Also bounds the Photo Limit input, the twin of the one fixed in e5f6085a:
min={0} with no max makes input[type=number] report aria-valuemax="0", and an
out-of-range value only failed at INSERT. Set to the events.photo_cap column's
real signed-32-bit ceiling.

Refs testplan REPORT.md B15 and the aria-valuemax warning.
---
 .../admin/event-details/EventInformationCard.tsx | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/frontend/src/pages/admin/event-details/EventInformationCard.tsx b/frontend/src/pages/admin/event-details/EventInformationCard.tsx
index e524da5a..5f2c2b9d 100644
--- a/frontend/src/pages/admin/event-details/EventInformationCard.tsx
+++ b/frontend/src/pages/admin/event-details/EventInformationCard.tsx
@@ -320,11 +320,16 @@ export const EventInformationCard: React.FC<EventInformationCardProps> = ({
             <select
               value={editForm.source_mode}
               onChange={(e) => {
-                const mode = e.target.value as 'managed' | 'reference';
+                // Named `sourceMode`, not `mode`: the i18n extractor's TS
+                // resolver matches locals by name across the whole file, so a
+                // local called `mode` here leaked 'managed' | 'reference' into
+                // the promo/info banner mode_ templates further down and had it
+                // emit four phantom keys that the code can never request.
+                const sourceMode = e.target.value as 'managed' | 'reference';
                 setEditForm(prev => ({
                   ...prev,
-                  source_mode: mode,
-                  external_path: mode === 'reference'
+                  source_mode: sourceMode,
+                  external_path: sourceMode === 'reference'
                     ? (prev.external_path || event.external_path || '')
                     : ''
                 }));
@@ -365,6 +370,11 @@ export const EventInformationCard: React.FC<EventInformationCardProps> = ({
                 value={editForm.photo_cap}
                 onChange={(e) => setEditForm(prev => ({ ...prev, photo_cap: parseInt(e.target.value) || 0 }))}
                 min={0}
+                // events.photo_cap is a signed 32-bit int (migration 074).
+                // Without an explicit max, input[type=number] reports
+                // aria-valuemax="0", and an out-of-range value only fails at
+                // INSERT.
+                max={2147483647}
                 className="w-24 px-3 py-2 border border-neutral-300 dark:border-neutral-600 bg-white dark:bg-neutral-800 text-neutral-900 dark:text-neutral-100 rounded-lg focus:ring-2 focus:ring-primary-500 focus:border-accent-dark"
               />
               <span className="text-xs text-neutral-500 dark:text-neutral-400">