fix: resolve feedback validation issues from GitHub issue #16
- Fixed backend validation to properly handle empty strings in validateGuestRequirements - Added Boolean conversion for SQLite boolean values in feedback settings API response - Created FeedbackIdentityModal component for collecting name/email when required - Updated PhotoLikes, PhotoRating, and PhotoFavorites components to show modal when requireNameEmail is true - Fixed issue where require_name_email field was not reaching frontend due to missing boolean conversion This ensures that when 'Require Name & Email' is enabled, guests are prompted with a modal to provide their information before submitting feedback, preventing 400 Bad Request errors. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -227,11 +227,17 @@ async function validateGuestRequirements(settings, guestData) {
|
||||
|
||||
const errors = [];
|
||||
|
||||
if (!guestData.guest_name || guestData.guest_name.trim().length === 0) {
|
||||
// Check for name - handle both undefined and empty strings
|
||||
const name = guestData.guest_name;
|
||||
if (!name || (typeof name === 'string' && name.trim().length === 0)) {
|
||||
errors.push('Name is required');
|
||||
}
|
||||
|
||||
if (!guestData.guest_email || !validator.isEmail(guestData.guest_email)) {
|
||||
// Check for email - handle both undefined and empty strings
|
||||
const email = guestData.guest_email;
|
||||
if (!email || (typeof email === 'string' && email.trim().length === 0)) {
|
||||
errors.push('Valid email is required');
|
||||
} else if (email && !validator.isEmail(email.trim())) {
|
||||
errors.push('Valid email is required');
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user