paul/picpeak
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

test(backup-integrity): tolerate both knex .returning('id') return shapes

Browse Source 
CI's SQLite returned `[N]` (plain int) from `.insert().returning('id')`
while local SQLite returned `[{ id: N }]` (object form). The brittle
`const [{ id }] = ...` destructure crashed on the int shape. Switched
to the unwrap pattern used by the existing crmDb test harness so the
suite runs on both PG and every SQLite/knex combo the project supports.
This commit is contained in:
Luca
2026-05-29 13:25:36 +02:00
parent 7e2feca12f
commit 614c8b9b8f
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/__tests__/services/backupIntegrityService.test.js
+7 -4
View File
@@ -77,7 +77,10 @@ describe('backupIntegrityService.verifyDocumentArtefacts', () => {
it('flags a contract whose signed_pdf_path file is missing', async () => { it('flags a contract whose signed_pdf_path file is missing', async () => {
// Reference a file that we deliberately never create on disk. // Reference a file that we deliberately never create on disk.
const [{ id }] = await db('contracts').insert({ // knex's `.returning('id')` returns `[{ id: N }]` on Postgres and
// newer SQLite, but `[N]` (plain int) on some SQLite versions —
// unwrap both shapes the same way the crmDb test harness does.
const inserted = await db('contracts').insert({
customer_account_id: customerId, customer_account_id: customerId,
contract_number: 'C-2026-MISSING', contract_number: 'C-2026-MISSING',
status: 'sent', status: 'sent',
@@ -85,7 +88,7 @@ describe('backupIntegrityService.verifyDocumentArtefacts', () => {
signed_pdf_path: 'business-docs/contract/2026/C-2026-MISSING.pdf', signed_pdf_path: 'business-docs/contract/2026/C-2026-MISSING.pdf',
created_at: new Date(), created_at: new Date(),
}).returning('id'); }).returning('id');
const contractId = typeof id === 'object' ? id.id : id; const contractId = typeof inserted[0] === 'object' ? inserted[0].id : inserted[0];
const report = await backupIntegrityService.verifyDocumentArtefacts({ scope: ['contract'] }); const report = await backupIntegrityService.verifyDocumentArtefacts({ scope: ['contract'] });
const hit = report.missing.find((m) => m.rowId === contractId); const hit = report.missing.find((m) => m.rowId === contractId);
@@ -123,7 +126,7 @@ describe('backupIntegrityService.verifyDocumentArtefacts', () => {
'business-docs/contract/2026/C-2026-TAMPER.pdf', 'business-docs/contract/2026/C-2026-TAMPER.pdf',
'tampered bytes on disk', 'tampered bytes on disk',
); );
const [{ id }] = await db('contracts').insert({ const inserted = await db('contracts').insert({
customer_account_id: customerId, customer_account_id: customerId,
contract_number: 'C-2026-TAMPER', contract_number: 'C-2026-TAMPER',
status: 'fully_signed', status: 'fully_signed',
@@ -134,7 +137,7 @@ describe('backupIntegrityService.verifyDocumentArtefacts', () => {
signed_pdf_sha256: sha256('the ORIGINAL bytes the customer signed'), signed_pdf_sha256: sha256('the ORIGINAL bytes the customer signed'),
created_at: new Date(), created_at: new Date(),
}).returning('id'); }).returning('id');
const contractId = typeof id === 'object' ? id.id : id; const contractId = typeof inserted[0] === 'object' ? inserted[0].id : inserted[0];
const report = await backupIntegrityService.verifyDocumentArtefacts({ scope: ['contract'] }); const report = await backupIntegrityService.verifyDocumentArtefacts({ scope: ['contract'] });
const hit = report.hashMismatches.find((m) => m.rowId === contractId); const hit = report.hashMismatches.find((m) => m.rowId === contractId);