fix(crm): pre-event reminder resolves recipient from the event row, not a non-existent column

The reminder query joined customer_accounts on events.customer_account_id — a column the events table doesn't have (events store the recipient inline as customer_email/host_email, like the gallery emails). So the query threw, the run failed, and no pre-event email went out for an event that has an email but no CRM customer account. Latent in the legacy pass (gated off by default); surfaced the moment the pre_event_email flow ran notify_pre_event. Both runEventReminderPass and sendReminderForEvent now read the recipient from the event's own columns (customer_email || host_email, name from customer_name || host_name) via SELECT events.* — no join, safe on installs predating the customer_email column. Regression test covers an event with a direct email and no customer account.
2026-06-24 01:30:35 +02:00
parent dee8d40bb3
commit 5fbe514db6
2 changed files with 55 additions and 62 deletions
@@ -378,6 +378,30 @@ describe('workflow engine', () => {
    expect(runs2.length).toBe(1);
  });

+  test('notify_pre_event / sendReminderForEvent sends to an event with a direct email (no CRM account)', async () => {
+    // Regression: the reminder query used events.customer_account_id, which does
+    // not exist — so an event with only customer_email/host_email got no mail.
+    const farFuture = new Date(Date.now() + 365 * 86400000).toISOString();
+    await db('events').insert({
+      event_type: 'wedding', password_hash: 'x', expires_at: farFuture,
+      is_active: true, is_archived: false,
+      slug: 'rem-direct', share_link: 'rem-direct', event_name: 'Direct',
+      event_date: new Date(Date.now() + 2 * 86400000).toISOString().slice(0, 10),
+      customer_email: 'direct@x.test', // event-level email, NOT a customer_account
+    });
+    const ev = await db('events').where({ slug: 'rem-direct' }).first();
+
+    const res = await require('../../src/services/eventReminderService').sendReminderForEvent(ev.id);
+    expect(res.sent).toBe(1);
+    const mail = await db('email_queue').where({ event_id: ev.id }).first();
+    expect(mail).toBeTruthy();
+    expect(mail.recipient_email).toBe('direct@x.test');
+    // Idempotent: sent_at stamped → a second call is a no-op.
+    const again = await require('../../src/services/eventReminderService').sendReminderForEvent(ev.id);
+    expect(again.sent).toBe(0);
+    expect(again.reason).toBe('already_sent');
+  });
+
  test('isBuiltinFlowActive reflects the built-in ENABLED state (enabled-based mutex)', async () => {
    const { seedBuiltinWorkflowsAtBoot } = require('../../src/services/_workflowSeedBoot');
    await seedBuiltinWorkflowsAtBoot(db, { info() {}, warn() {} });