feat(accounting): re-categorize incoming invoices, note field, pending re-bill pool

Address three incoming-invoice issues:

1. Re-categorization: a categorized invoice can now be changed again (e.g.
   passthrough → company expense). New "Re-categorize" button pre-fills the
   triage modal from the existing disposition/customer/markup/note.
   categorizeInbound is re-runnable — it unwinds any prior re-bill line
   (removes the invoice line + recomputes totals) before applying the new
   disposition, and refuses (INVOICE_LOCKED) when the re-bill is on an
   already-issued invoice.

2. Note field: new `note` column (migration 132 — 126 is already on beta)
   captured in triage and shown in the read-only view.

3. Re-bill like hours: rebill/passthrough now persist customer_account_id.
   Per-event customers accumulate as PENDING items, surfaced in a new
   "Pending re-bills" card and bundled into one invoice via "Bill these"
   (mirrors unbilled-hours billing). Monthly/manual customers keep
   auto-consolidating onto their running draft. Passthrough (durchlaufend)
   can now also attach to a customer with optional markup.

Adds backend unit tests for buildInboundLineItem + isInvoiceMutable and
en/de translations (other locales fall back to English defaults).
This commit is contained in:
Luca
2026-06-18 12:23:13 +02:00
parent 8deb7e0741
commit 36a8e42f90
8 changed files with 553 additions and 76 deletions
@@ -4,7 +4,7 @@
*/ */
const expenseService = require('../../src/services/expenseService'); const expenseService = require('../../src/services/expenseService');
const { computeMarkupMinor, resolveMarkup, computeExpenseAmount, buildExpenseInsert } = expenseService._internal; const { computeMarkupMinor, resolveMarkup, computeExpenseAmount, buildExpenseInsert, buildInboundLineItem, isInvoiceMutable } = expenseService._internal;
describe('computeMarkupMinor', () => { describe('computeMarkupMinor', () => {
it('percent of base, rounded', () => { it('percent of base, rounded', () => {
@@ -85,3 +85,48 @@ describe('buildExpenseInsert (internal expense)', () => {
expect(evt.event_id).toBe(9); expect(evt.event_id).toBe(9);
}); });
}); });
describe('buildInboundLineItem (re-bill line)', () => {
it('rebill: base + percent markup, Weiterverrechnung suffix', () => {
const li = buildInboundLineItem({ totalAmountMinor: 10000, supplierName: 'ACME' }, 'rebill', { type: 'percent', percent: 10 });
expect(li.unit_price_minor).toBe(11000);
expect(li.line_total_minor).toBe(11000);
expect(li.quantity).toBe(1);
expect(li.description).toBe('ACME (Weiterverrechnung)');
});
it('passthrough: distinct suffix, no markup passes through at cost', () => {
const li = buildInboundLineItem({ totalAmountMinor: 5000, supplierName: 'SBB' }, 'durchlaufend', { type: 'none' });
expect(li.unit_price_minor).toBe(5000);
expect(li.description).toBe('SBB (Durchlaufende Position)');
});
it('falls back to net amount + generic label when total/supplier missing', () => {
const li = buildInboundLineItem({ totalAmountMinor: null, netAmountMinor: 7000 }, 'rebill', { type: 'flat', flatMinor: 300 });
expect(li.unit_price_minor).toBe(7300);
expect(li.description).toBe('Weiterverrechnete Auslage (Weiterverrechnung)');
});
it('throws when there is no amount to re-bill', () => {
expect(() => buildInboundLineItem({ totalAmountMinor: null, netAmountMinor: null }, 'rebill', { type: 'none' }))
.toThrow(/no amount/i);
});
});
describe('isInvoiceMutable (re-categorise unwind guard)', () => {
const future = new Date(Date.now() + 86400000).toISOString();
const past = new Date(Date.now() - 86400000).toISOString();
it('monthly draft and not-yet-armed scheduled are mutable', () => {
expect(isInvoiceMutable(null)).toBe(true); // referenced invoice gone
expect(isInvoiceMutable({ is_monthly_draft: true })).toBe(true);
expect(isInvoiceMutable({ is_monthly_draft: 1 })).toBe(true);
expect(isInvoiceMutable({ status: 'scheduled', scheduled_send_at: null })).toBe(true);
expect(isInvoiceMutable({ status: 'scheduled', scheduled_send_at: future })).toBe(true);
});
it('armed / issued invoices are locked', () => {
expect(isInvoiceMutable({ status: 'scheduled', scheduled_send_at: past })).toBe(false);
expect(isInvoiceMutable({ status: 'sent' })).toBe(false);
expect(isInvoiceMutable({ status: 'paid' })).toBe(false);
expect(isInvoiceMutable({ status: 'cancelled' })).toBe(false);
});
});
@@ -0,0 +1,48 @@
/**
* Migration 132: incoming-invoice categorisation note + customer linkage.
*
* - note : free-text note captured during triage (issue: no
* note field on categorisation).
* - customer_account_id: the client a rebill/passthrough is attached to.
* Previously the customer was passed transiently to
* the re-bill call and only lived on the resulting
* invoice. Persisting it lets a categorised-but-not-
* yet-billed item sit as a PENDING re-bill in the
* customer's pool (per-event customers), exactly like
* unbilled hour entries. Loose link (no hard FK —
* mirrors the inbound event_id / expenses approach),
* indexed for the pending-summary lookup.
*
* Migration 126 (which added the disposition/re-bill columns) is already
* deployed to beta, so these go in a NEW migration rather than an in-place
* edit. Additive + hasColumn-guarded so re-runs are safe.
*/
async function addColumn(knex, table, column, builder) {
// eslint-disable-next-line no-await-in-loop
if (!(await knex.schema.hasColumn(table, column))) {
await knex.schema.alterTable(table, builder);
}
}
exports.up = async function (knex) {
if (!(await knex.schema.hasTable('inbound_documents'))) return;
await addColumn(knex, 'inbound_documents', 'note', (t) => t.text('note'));
await addColumn(knex, 'inbound_documents', 'customer_account_id', (t) => t.integer('customer_account_id').unsigned());
if (await knex.schema.hasColumn('inbound_documents', 'customer_account_id')) {
// Index the pending-rebill lookup (customer_account_id + billed_invoice_id).
try {
await knex.schema.alterTable('inbound_documents', (t) => t.index(['customer_account_id'], 'inbound_documents_customer_account_id_index'));
} catch (_e) { /* index may already exist */ }
}
};
exports.down = async function (knex) {
if (!(await knex.schema.hasTable('inbound_documents'))) return;
for (const col of ['note', 'customer_account_id']) {
// eslint-disable-next-line no-await-in-loop
if (await knex.schema.hasColumn('inbound_documents', col)) {
// eslint-disable-next-line no-await-in-loop
await knex.schema.alterTable('inbound_documents', (t) => t.dropColumn(col));
}
}
};
+16 -1
View File
@@ -101,6 +101,17 @@ router.get('/inbound', requireIncoming, requirePermission('accounting.view'),
[query('status').optional().isString(), query('page').optional().isInt({ min: 1 }), query('pageSize').optional().isInt({ min: 1, max: 100 })], [query('status').optional().isString(), query('page').optional().isInt({ min: 1 }), query('pageSize').optional().isInt({ min: 1, max: 100 })],
handleAsync(async (req, res) => { validateRequest(req); return successResponse(res, await expenseService.listInbound(req.query)); })); handleAsync(async (req, res) => { validateRequest(req); return successResponse(res, await expenseService.listInbound(req.query)); }));
// Pending re-bills grouped by customer (per-event customers with categorised
// but not-yet-billed rebill/passthrough docs). Registered BEFORE /inbound/:id
// so the literal path isn't swallowed by the :id param matcher.
router.get('/inbound/pending-summary', requireIncoming, requirePermission('accounting.view'),
handleAsync(async (_req, res) => successResponse(res, { items: await expenseService.listPendingRebillSummary() })));
// Bundle a customer's pending re-bills into one invoice (per-event only).
router.post('/inbound/bill-pending', requireIncoming, requirePermission('accounting.manage'),
[body('customerAccountId').isInt({ min: 1 })],
handleAsync(async (req, res) => { validateRequest(req); return successResponse(res, await expenseService.billPendingRebills(toInt(req.body.customerAccountId), req.admin.id), 201, 'Re-billed'); }));
router.get('/inbound/:id/file', requireIncoming, requirePermission('accounting.view'), router.get('/inbound/:id/file', requireIncoming, requirePermission('accounting.view'),
[param('id').isInt({ min: 1 })], [param('id').isInt({ min: 1 })],
handleAsync(async (req, res) => { handleAsync(async (req, res) => {
@@ -144,7 +155,11 @@ router.patch('/inbound/:id', requireIncoming, requirePermission('accounting.mana
handleAsync(async (req, res) => { validateRequest(req); return successResponse(res, { document: await expenseService.updateInbound(toInt(req.params.id), req.body, req.admin.id) }); })); handleAsync(async (req, res) => { validateRequest(req); return successResponse(res, { document: await expenseService.updateInbound(toInt(req.params.id), req.body, req.admin.id) }); }));
router.post('/inbound/:id/categorize', requireIncoming, requirePermission('accounting.manage'), router.post('/inbound/:id/categorize', requireIncoming, requirePermission('accounting.manage'),
[param('id').isInt({ min: 1 }), body('disposition').isIn(expenseService.DISPOSITIONS)], [param('id').isInt({ min: 1 }), body('disposition').isIn(expenseService.DISPOSITIONS),
body('customerAccountId').optional({ nullable: true }).isInt({ min: 1 }),
body('eventId').optional({ nullable: true }).isInt({ min: 1 }),
body('categoryId').optional({ nullable: true }).isInt({ min: 1 }),
body('markupType').optional().isIn(expenseService.MARKUP_TYPES)],
handleAsync(async (req, res) => { validateRequest(req); return successResponse(res, { document: await expenseService.categorizeInbound(toInt(req.params.id), req.body, req.admin.id) }, 200, 'Categorized'); })); handleAsync(async (req, res) => { validateRequest(req); return successResponse(res, { document: await expenseService.categorizeInbound(toInt(req.params.id), req.body, req.admin.id) }, 200, 'Categorized'); }));
router.post('/inbound/:id/rebill', requireIncoming, requirePermission('accounting.manage'), router.post('/inbound/:id/rebill', requireIncoming, requirePermission('accounting.manage'),
+308 -55
View File
@@ -96,6 +96,13 @@ function transformInbound(row) {
markupFlatMinor: row.markup_flat_minor, markupFlatMinor: row.markup_flat_minor,
billedInvoiceId: row.billed_invoice_id, billedInvoiceId: row.billed_invoice_id,
billedInvoiceLineItemId: row.billed_invoice_line_item_id, billedInvoiceLineItemId: row.billed_invoice_line_item_id,
// re-bill customer linkage (migration 132) — the client a rebill/passthrough
// is attached to. customerName/Email are denormalised from a LEFT JOIN in
// list/get (null when the row came from a query without the join).
customerAccountId: row.customer_account_id || null,
customerName: row.customer_display_name || row.customer_company_name || null,
customerEmail: row.customer_email || null,
note: row.note || null,
// supplier payment (paid on the incoming invoice itself) // supplier payment (paid on the incoming invoice itself)
supplierPaid: !!row.supplier_paid, supplierPaid: !!row.supplier_paid,
supplierPaidAt: row.supplier_paid_at, supplierPaidAt: row.supplier_paid_at,
@@ -168,19 +175,34 @@ async function recordInboundDocument({ source, filePath, originalFilename, mimeT
return getInbound(id); return getInbound(id);
} }
// Denormalise the attached customer's name/email for the inbox UI (re-bill
// chip + pending-pool grouping). LEFT JOIN so docs without a customer still
// return. Selected explicitly to avoid colliding with inbound_documents.*.
const INBOUND_CUSTOMER_SELECT = [
'inbound_documents.*',
'c.display_name as customer_display_name',
'c.company_name as customer_company_name',
'c.email as customer_email',
];
function inboundWithCustomer() {
return db('inbound_documents')
.leftJoin('customer_accounts as c', 'inbound_documents.customer_account_id', 'c.id');
}
async function getInbound(id) { async function getInbound(id) {
const row = await db('inbound_documents').where({ id }).first(); const row = await inboundWithCustomer().where('inbound_documents.id', id).first(INBOUND_CUSTOMER_SELECT);
if (!row) throw new AppError('Incoming invoice not found', 404, 'INBOUND_NOT_FOUND'); if (!row) throw new AppError('Incoming invoice not found', 404, 'INBOUND_NOT_FOUND');
return transformInbound(row); return transformInbound(row);
} }
async function listInbound({ status, page, pageSize } = {}) { async function listInbound({ status, page, pageSize } = {}) {
const { p, ps } = clampPage(page, pageSize); const { p, ps } = clampPage(page, pageSize);
const base = db('inbound_documents'); const base = inboundWithCustomer();
if (status) base.where({ status }); if (status) base.where('inbound_documents.status', status);
const countRow = await base.clone().count({ count: '*' }).first(); const countRow = await base.clone().clearSelect().count({ count: 'inbound_documents.id' }).first();
const total = parseInt(countRow?.count || 0, 10); const total = parseInt(countRow?.count || 0, 10);
const rows = await base.clone().orderBy('created_at', 'desc').limit(ps).offset((p - 1) * ps); const rows = await base.clone().orderBy('inbound_documents.created_at', 'desc').limit(ps).offset((p - 1) * ps)
.select(INBOUND_CUSTOMER_SELECT);
return { items: rows.map(transformInbound), pagination: { page: p, pageSize: ps, total, totalPages: Math.ceil(total / ps) } }; return { items: rows.map(transformInbound), pagination: { page: p, pageSize: ps, total, totalPages: Math.ceil(total / ps) } };
} }
@@ -188,7 +210,7 @@ const INBOUND_EDITABLE = {
supplierName: 'supplier_name', invoiceNumber: 'invoice_number', invoiceDate: 'invoice_date', supplierName: 'supplier_name', invoiceNumber: 'invoice_number', invoiceDate: 'invoice_date',
dueDate: 'due_date', currency: 'currency', netAmountMinor: 'net_amount_minor', dueDate: 'due_date', currency: 'currency', netAmountMinor: 'net_amount_minor',
vatAmountMinor: 'vat_amount_minor', totalAmountMinor: 'total_amount_minor', iban: 'iban', vatAmountMinor: 'vat_amount_minor', totalAmountMinor: 'total_amount_minor', iban: 'iban',
paymentReference: 'payment_reference', paymentReference: 'payment_reference', note: 'note',
}; };
async function updateInbound(id, payload, adminId) { async function updateInbound(id, payload, adminId) {
@@ -232,79 +254,308 @@ function computeMarkupMinor(baseMinor, markup) {
return 0; return 0;
} }
/** Re-bill an incoming invoice to a client (mints an editable scheduled invoice). */ // Dispositions that can be billed to a client. 'rebill' always carries a
// customer; 'durchlaufend' (passthrough) may now ALSO attach to a customer
// (with optional markup) so it can be re-billed like a rebill.
const CUSTOMER_DISPOSITIONS = ['rebill', 'durchlaufend'];
const BOOKING_DISPOSITIONS = ['rebill', 'durchlaufend'];
/**
* Can this invoice still be edited (line removed / appended)? Mirrors the
* hour-entry lock rules (customerHoursService.isEntryLocked, inverted):
* monthly drafts and not-yet-armed scheduled invoices are mutable; anything
* sent/paid/overdue/cancelled or past its scheduled_send_at is locked.
*/
function isInvoiceMutable(invoice) {
if (!invoice) return true; // referenced invoice gone — treat as not billed
if (invoice.is_monthly_draft === true || invoice.is_monthly_draft === 1) return true;
if (invoice.status !== 'scheduled') return false;
if (!invoice.scheduled_send_at) return true;
return new Date(invoice.scheduled_send_at).getTime() > Date.now();
}
/**
* Re-categorisation unwind: remove this document's billed line item from its
* invoice and recompute the invoice totals, so the disposition can change.
* Refuses when the invoice is already issued (Storno required instead).
*/
async function unwindBilledLine(trx, doc) {
const invoice = doc.billedInvoiceId
? await trx('invoices').where({ id: doc.billedInvoiceId }).first()
: null;
if (invoice && !isInvoiceMutable(invoice)) {
throw new AppError(
'This re-bill is on an invoice that has already been issued — Storno it before re-categorising.',
409, 'INVOICE_LOCKED',
);
}
if (doc.billedInvoiceLineItemId) {
await trx('invoice_line_items').where({ id: doc.billedInvoiceLineItemId }).del();
}
if (invoice) {
const allItems = await trx('invoice_line_items').where({ invoice_id: invoice.id });
let netMinor = 0;
for (const li of allItems) {
if (li.parent_line_item_id == null) netMinor += Number(li.line_total_minor || 0);
}
const vatRate = Number(invoice.vat_rate || 0);
const vatMinor = Math.round(netMinor * vatRate / 100);
const shippingMinor = Number(invoice.shipping_amount_minor || 0);
await trx('invoices').where({ id: invoice.id }).update({
net_amount_minor: netMinor,
vat_amount_minor: vatMinor,
total_amount_minor: netMinor + vatMinor + shippingMinor,
updated_at: new Date(),
});
}
}
/** The single invoice line that re-bills one incoming invoice (base + markup). */
function buildInboundLineItem(doc, disposition, markup) {
const base = doc.totalAmountMinor != null ? doc.totalAmountMinor : doc.netAmountMinor;
if (base == null) throw new AppError('Incoming invoice has no amount to re-bill', 400, 'AMOUNT_REQUIRED');
const lineTotal = base + computeMarkupMinor(base, markup);
const label = doc.supplierName || 'Weiterverrechnete Auslage';
const suffix = disposition === 'durchlaufend' ? ' (Durchlaufende Position)' : ' (Weiterverrechnung)';
return { description: `${label}${suffix}`, quantity: 1, unit_price_minor: lineTotal, discount_percent: 0, line_total_minor: lineTotal };
}
/**
* Immediately bill ONE incoming invoice to its customer. createInvoice routes
* monthly/manual customers onto the running draft (consolidated, like hours)
* and mints a standalone invoice for per-event customers. Stamps the document
* with the resulting invoice + line.
*/
async function billInboundNow(trx, id, customerAccountId, eventId, disposition, markup, adminId) {
const row = await trx('inbound_documents').where({ id }).first();
const doc = transformInbound(row);
const lineItem = buildInboundLineItem(doc, disposition, markup);
const { invoiceIds } = await invoiceService.createInvoice({
customerAccountId,
eventId: eventId || doc.eventId || null,
lineItems: [lineItem],
}, adminId, trx);
const invoiceId = Array.isArray(invoiceIds) ? invoiceIds[0] : null;
if (!invoiceId) throw new AppError('Failed to create the re-bill invoice', 500, 'REBILL_FAILED');
const line = await trx('invoice_line_items').where({ invoice_id: invoiceId }).orderBy('id', 'desc').first('id');
await trx('inbound_documents').where({ id }).update({
billed_invoice_id: invoiceId,
billed_invoice_line_item_id: line ? line.id : null,
updated_at: new Date(),
});
await logActivity('incoming_invoice_rebilled', { inboundDocumentId: id, invoiceId }, adminId);
return invoiceId;
}
/**
* Give an incoming invoice a disposition (updates the document, no expense
* row). Re-runnable: re-categorising an already-billed document first unwinds
* its prior re-bill line. For rebill/passthrough with a customer, monthly &
* manual customers are billed immediately onto the running draft (like hours);
* per-event customers stay PENDING in the customer's pool until "Bill these".
*/
async function categorizeInbound(id, payload, adminId) {
const disposition = payload.disposition;
if (!DISPOSITIONS.includes(disposition)) {
throw new AppError(`disposition must be one of ${DISPOSITIONS.join(', ')}`, 400, 'BAD_DISPOSITION');
}
const billsToCustomer = CUSTOMER_DISPOSITIONS.includes(disposition);
const customerAccountId = billsToCustomer && payload.customerAccountId ? payload.customerAccountId : null;
// rebill REQUIRES a customer; passthrough may omit one (then it's only booked
// to an event/company and never re-billed).
if (disposition === 'rebill' && !customerAccountId) {
throw new AppError('customerAccountId is required to re-bill', 400, 'CUSTOMER_REQUIRED');
}
await db.transaction(async (trx) => {
const row = await trx('inbound_documents').where({ id }).first();
if (!row) throw new AppError('Incoming invoice not found', 404, 'INBOUND_NOT_FOUND');
const doc = transformInbound(row);
// #1: unwind any prior re-bill so the disposition can change.
if (doc.billedInvoiceId) await unwindBilledLine(trx, doc);
const markup = billsToCustomer
? await resolveMarkup(
{ markupType: payload.markupType, markupPercent: payload.markupPercent, markupFlatMinor: payload.markupFlatMinor },
payload, payload.contractId, trx,
)
: { type: 'none', percent: null, flatMinor: null };
const patch = {
disposition,
tax_treatment: TAX_TREATMENTS.includes(payload.taxTreatment) ? payload.taxTreatment : 'domestic',
event_id: BOOKING_DISPOSITIONS.includes(disposition) ? (payload.eventId || null) : null,
category_id: disposition === 'eigener_aufwand' ? (payload.categoryId || null) : null,
customer_account_id: customerAccountId,
markup_type: billsToCustomer ? markup.type : 'none',
markup_percent: billsToCustomer && markup.type === 'percent' ? markup.percent : null,
markup_flat_minor: billsToCustomer && markup.type === 'flat' ? markup.flatMinor : null,
// Cleared here; re-set by billInboundNow when we bill immediately.
billed_invoice_id: null,
billed_invoice_line_item_id: null,
status: DISPOSITION_DOC_STATUS[disposition] || 'categorized',
updated_at: new Date(),
};
if (disposition === 'duplikat' && payload.duplicateOfId) patch.duplicate_of_id = payload.duplicateOfId;
await trx('inbound_documents').where({ id }).update(patch);
if (customerAccountId) {
const customer = await trx('customer_accounts').where({ id: customerAccountId }).first();
if (!customer) throw new AppError('Customer not found', 404, 'CUSTOMER_NOT_FOUND');
// Monthly/manual = accumulator → bill now onto the running draft.
// Per-event → leave PENDING for bundling via billPendingRebills.
if (customer.billing_cadence === 'monthly' || customer.billing_cadence === 'manual') {
await billInboundNow(trx, id, customerAccountId, payload.eventId || null, disposition, markup, adminId);
}
}
await logActivity('incoming_invoice_categorized', { inboundDocumentId: id, disposition }, adminId);
});
return getInbound(id);
}
/**
* Explicit "re-bill this one now" endpoint (legacy /inbound/:id/rebill). Forces
* an immediate single-document bill regardless of cadence. Re-runnable: unwinds
* a prior re-bill first.
*/
async function rebillInbound(id, payload, adminId, trx0) { async function rebillInbound(id, payload, adminId, trx0) {
if (!payload.customerAccountId) throw new AppError('customerAccountId is required to re-bill', 400, 'CUSTOMER_REQUIRED');
const run = async (trx) => { const run = async (trx) => {
const row = await trx('inbound_documents').where({ id }).first(); const row = await trx('inbound_documents').where({ id }).first();
if (!row) throw new AppError('Incoming invoice not found', 404, 'INBOUND_NOT_FOUND'); if (!row) throw new AppError('Incoming invoice not found', 404, 'INBOUND_NOT_FOUND');
const doc = transformInbound(row); const doc = transformInbound(row);
if (doc.billedInvoiceId) throw new AppError('Already re-billed', 409, 'ALREADY_BILLED'); if (doc.billedInvoiceId) await unwindBilledLine(trx, doc);
if (!payload.customerAccountId) throw new AppError('customerAccountId is required to re-bill', 400, 'CUSTOMER_REQUIRED');
const base = doc.totalAmountMinor != null ? doc.totalAmountMinor : doc.netAmountMinor;
if (base == null) throw new AppError('Incoming invoice has no amount to re-bill', 400, 'AMOUNT_REQUIRED');
const markup = await resolveMarkup( const markup = await resolveMarkup(
{ markupType: doc.markupType, markupPercent: doc.markupPercent, markupFlatMinor: doc.markupFlatMinor }, { markupType: doc.markupType, markupPercent: doc.markupPercent, markupFlatMinor: doc.markupFlatMinor },
payload, payload.contractId, trx, payload, payload.contractId, trx,
); );
const lineTotal = base + computeMarkupMinor(base, markup);
const label = doc.supplierName || 'Weiterverrechnete Auslage';
const { invoiceIds } = await invoiceService.createInvoice({
customerAccountId: payload.customerAccountId,
eventId: payload.eventId || doc.eventId || null,
lineItems: [{ description: `${label} (Weiterverrechnung)`, quantity: 1, unit_price_minor: lineTotal, discount_percent: 0, line_total_minor: lineTotal }],
}, adminId, trx);
const invoiceId = Array.isArray(invoiceIds) ? invoiceIds[0] : null;
if (!invoiceId) throw new AppError('Failed to create the re-bill invoice', 500, 'REBILL_FAILED');
const line = await trx('invoice_line_items').where({ invoice_id: invoiceId }).orderBy('id', 'desc').first('id');
await trx('inbound_documents').where({ id }).update({ await trx('inbound_documents').where({ id }).update({
disposition: 'rebill', disposition: 'rebill',
status: 'categorized', status: 'categorized',
customer_account_id: payload.customerAccountId,
event_id: payload.eventId || doc.eventId || null, event_id: payload.eventId || doc.eventId || null,
markup_type: markup.type, markup_type: markup.type,
markup_percent: markup.type === 'percent' ? markup.percent : null, markup_percent: markup.type === 'percent' ? markup.percent : null,
markup_flat_minor: markup.type === 'flat' ? markup.flatMinor : null, markup_flat_minor: markup.type === 'flat' ? markup.flatMinor : null,
billed_invoice_id: invoiceId,
billed_invoice_line_item_id: line ? line.id : null,
updated_at: new Date(), updated_at: new Date(),
}); });
await logActivity('incoming_invoice_rebilled', { inboundDocumentId: id, invoiceId }, adminId); return billInboundNow(trx, id, payload.customerAccountId, payload.eventId || doc.eventId || null, 'rebill', markup, adminId);
return invoiceId;
}; };
const invoiceId = trx0 ? await run(trx0) : await db.transaction(run); const invoiceId = trx0 ? await run(trx0) : await db.transaction(run);
return { document: await getInbound(id), invoiceId }; return { document: await getInbound(id), invoiceId };
} }
/** Give an incoming invoice a disposition (updates the document, no expense row). */ /**
async function categorizeInbound(id, payload, adminId) { * Landing aggregate for the inbox "pending re-bills" card: one row per customer
const doc = await getInbound(id); * that carries categorised-but-unbilled rebill/passthrough documents, with the
const disposition = payload.disposition; * count + open amount (base + markup). In practice only per-event customers
if (!DISPOSITIONS.includes(disposition)) { * surface here — monthly/manual cadences bill immediately on categorise.
throw new AppError(`disposition must be one of ${DISPOSITIONS.join(', ')}`, 400, 'BAD_DISPOSITION'); */
async function listPendingRebillSummary() {
const rows = await db('inbound_documents as d')
.join('customer_accounts as c', 'd.customer_account_id', 'c.id')
.whereNotNull('d.customer_account_id')
.whereNull('d.billed_invoice_id')
.whereIn('d.disposition', CUSTOMER_DISPOSITIONS)
.where('d.status', 'categorized')
.select(
'd.customer_account_id', 'd.total_amount_minor', 'd.net_amount_minor',
'd.markup_type', 'd.markup_percent', 'd.markup_flat_minor',
'c.company_name', 'c.display_name', 'c.first_name', 'c.last_name',
'c.email', 'c.password_hash', 'c.billing_cadence',
);
const byCustomer = new Map();
for (const r of rows) {
let agg = byCustomer.get(r.customer_account_id);
if (!agg) {
agg = {
customerAccountId: r.customer_account_id,
companyName: r.company_name || null,
displayName: r.display_name || null,
firstName: r.first_name || null,
lastName: r.last_name || null,
email: r.email || null,
isPassive: r.password_hash == null,
billingCadence: r.billing_cadence || null,
itemCount: 0,
openAmountMinor: 0,
};
byCustomer.set(r.customer_account_id, agg);
}
agg.itemCount += 1;
const base = r.total_amount_minor != null ? Number(r.total_amount_minor)
: (r.net_amount_minor != null ? Number(r.net_amount_minor) : 0);
const markup = {
type: MARKUP_TYPES.includes(r.markup_type) ? r.markup_type : 'none',
percent: r.markup_percent != null ? Number(r.markup_percent) : null,
flatMinor: Number.isInteger(r.markup_flat_minor) ? r.markup_flat_minor : null,
};
agg.openAmountMinor += base + computeMarkupMinor(base, markup);
} }
if (disposition === 'rebill') {
const { document } = await rebillInbound(id, payload, adminId); return Array.from(byCustomer.values()).sort((a, b) => b.openAmountMinor - a.openAmountMinor);
// also stamp tax_treatment/category/event from payload }
await db('inbound_documents').where({ id }).update({
tax_treatment: TAX_TREATMENTS.includes(payload.taxTreatment) ? payload.taxTreatment : (document.taxTreatment || 'domestic'), /**
category_id: payload.categoryId || null, * Per-event flow: bundle all pending rebill/passthrough documents for a
updated_at: new Date(), * customer into ONE invoice, one line per document. Refuses for monthly/manual
}); * customers (those bill immediately on categorise). Mirrors
return getInbound(id); * customerHoursService.billUnbilledEntries.
*/
async function billPendingRebills(customerId, adminId) {
const customer = await db('customer_accounts').where({ id: customerId }).first();
if (!customer) throw new AppError('Customer not found', 404);
if (customer.billing_cadence === 'monthly' || customer.billing_cadence === 'manual') {
throw new AppError(
'Monthly/manual customers consolidate automatically on categorise; bundling is for per-event customers.',
409, 'CADENCE_MISMATCH',
);
} }
const patch = {
disposition, return await db.transaction(async (trx) => {
tax_treatment: TAX_TREATMENTS.includes(payload.taxTreatment) ? payload.taxTreatment : 'domestic', const pending = await trx('inbound_documents')
event_id: payload.eventId || null, // null = company .where({ customer_account_id: customer.id })
category_id: disposition === 'eigener_aufwand' ? (payload.categoryId || null) : null, .whereNull('billed_invoice_id')
status: DISPOSITION_DOC_STATUS[disposition] || 'categorized', .whereIn('disposition', CUSTOMER_DISPOSITIONS)
updated_at: new Date(), .where('status', 'categorized')
}; .orderBy('invoice_date', 'asc').orderBy('id', 'asc');
if (disposition === 'duplikat' && payload.duplicateOfId) patch.duplicate_of_id = payload.duplicateOfId; if (pending.length === 0) throw new AppError('No pending re-bills to bill', 409, 'NO_PENDING');
await db('inbound_documents').where({ id }).update(patch);
await logActivity('incoming_invoice_categorized', { inboundDocumentId: id, disposition }, adminId); const lineItems = [];
return getInbound(id); for (let i = 0; i < pending.length; i += 1) {
const doc = transformInbound(pending[i]);
// eslint-disable-next-line no-await-in-loop
const markup = await resolveMarkup(
{ markupType: doc.markupType, markupPercent: doc.markupPercent, markupFlatMinor: doc.markupFlatMinor },
null, null, trx,
);
lineItems.push({ ...buildInboundLineItem(doc, doc.disposition, markup), position: i + 1 });
}
const { invoiceIds } = await invoiceService.createInvoice({
customerAccountId: customer.id,
lineItems,
}, adminId, trx);
const invoiceId = invoiceIds[0];
const insertedLines = await trx('invoice_line_items').where({ invoice_id: invoiceId }).orderBy('position', 'asc');
const lineByPos = new Map(insertedLines.map((li) => [li.position, li.id]));
const now = new Date();
for (let i = 0; i < pending.length; i += 1) {
// eslint-disable-next-line no-await-in-loop
await trx('inbound_documents').where({ id: pending[i].id }).update({
billed_invoice_id: invoiceId,
billed_invoice_line_item_id: lineByPos.get(i + 1) || null,
updated_at: now,
});
}
await logActivity('incoming_invoices_rebilled_bundle', { customerId: customer.id, invoiceId, count: pending.length }, adminId);
return { invoiceId, count: pending.length };
});
} }
/** Mark the supplier paid on the incoming invoice (the payable lives here). */ /** Mark the supplier paid on the incoming invoice (the payable lives here). */
@@ -518,6 +769,8 @@ module.exports = {
updateInbound, updateInbound,
categorizeInbound, categorizeInbound,
rebillInbound, rebillInbound,
listPendingRebillSummary,
billPendingRebills,
markInboundSupplierPayment, markInboundSupplierPayment,
// expenses // expenses
createExpense, createExpense,
@@ -531,5 +784,5 @@ module.exports = {
PAYMENT_METHODS, PAYMENT_METHODS,
EXPENSE_KINDS, EXPENSE_KINDS,
// unit-test surface // unit-test surface
_internal: { computeMarkupMinor, resolveMarkup, computeExpenseAmount, buildExpenseInsert, transformExpense, transformInbound }, _internal: { computeMarkupMinor, resolveMarkup, computeExpenseAmount, buildExpenseInsert, transformExpense, transformInbound, buildInboundLineItem, isInvoiceMutable },
}; };
+14 -2
View File
@@ -3520,6 +3520,7 @@
"saveCategorize": "Speichern", "saveCategorize": "Speichern",
"saveCategorizePay": "Speichern & als bezahlt markieren", "saveCategorizePay": "Speichern & als bezahlt markieren",
"categorize": "Kategorisieren", "categorize": "Kategorisieren",
"recategorize": "Neu kategorisieren",
"view": "Ansehen", "view": "Ansehen",
"empty": "Noch keine Dokumente — oben eines erfassen.", "empty": "Noch keine Dokumente — oben eines erfassen.",
"untitled": "Unbenanntes Dokument", "untitled": "Unbenanntes Dokument",
@@ -3551,7 +3552,10 @@
"eventId": "Event-ID (optional)", "eventId": "Event-ID (optional)",
"markup": "Zuschlag", "markup": "Zuschlag",
"reference": "Zahlungsreferenz", "reference": "Zahlungsreferenz",
"referenceHint": "QR-/ESR-Referenz oder Mitteilung" "referenceHint": "QR-/ESR-Referenz oder Mitteilung",
"note": "Notiz",
"noteHint": "Interne Notiz zu dieser Rechnung (optional)",
"passthroughCustomerHint": "Optional — einen Kunden zuordnen, um diese durchlaufende Position weiterzuverrechnen; leer lassen, um sie nur auf das Event zu buchen."
} }
}, },
"expenseStatus": { "expenseStatus": {
@@ -3584,7 +3588,15 @@
"paid": "Bezahlt", "paid": "Bezahlt",
"paidToast": "Als bezahlt markiert.", "paidToast": "Als bezahlt markiert.",
"categorizedToast": "Kategorisiert.", "categorizedToast": "Kategorisiert.",
"categorizedPaidToast": "Kategorisiert und als bezahlt markiert." "categorizedPaidToast": "Kategorisiert und als bezahlt markiert.",
"pendingRebill": "Weiterverrechnung offen",
"pendingTitle": "Offene Weiterverrechnungen",
"pendingBody": "Kategorisierte Rechnungen, die auf die Weiterverrechnung warten. Posten eines Kunden zu einer Rechnung bündeln.",
"pendingCount": "{{count}} Posten",
"pendingCount_other": "{{count}} Posten",
"billPending": "Verrechnen",
"bundledToast": "{{count}} Weiterverrechnung zu einer Rechnung gebündelt.",
"bundledToast_other": "{{count}} Weiterverrechnungen zu einer Rechnung gebündelt."
}, },
"expense": { "expense": {
"kind": "Art", "kind": "Art",
+14 -2
View File
@@ -3520,6 +3520,7 @@
"saveCategorize": "Save", "saveCategorize": "Save",
"saveCategorizePay": "Save & mark paid", "saveCategorizePay": "Save & mark paid",
"categorize": "Categorize", "categorize": "Categorize",
"recategorize": "Re-categorize",
"view": "View", "view": "View",
"empty": "No documents yet — capture one above.", "empty": "No documents yet — capture one above.",
"untitled": "Untitled document", "untitled": "Untitled document",
@@ -3551,7 +3552,10 @@
"eventId": "Event ID (optional)", "eventId": "Event ID (optional)",
"markup": "Markup", "markup": "Markup",
"reference": "Payment reference", "reference": "Payment reference",
"referenceHint": "QR / ESR reference or message" "referenceHint": "QR / ESR reference or message",
"note": "Note",
"noteHint": "Internal note for this invoice (optional)",
"passthroughCustomerHint": "Optional — attach a client to re-bill this passthrough; leave empty to only book it to the event."
} }
}, },
"expenseStatus": { "expenseStatus": {
@@ -3584,7 +3588,15 @@
"paid": "Paid", "paid": "Paid",
"paidToast": "Marked as paid.", "paidToast": "Marked as paid.",
"categorizedToast": "Categorized.", "categorizedToast": "Categorized.",
"categorizedPaidToast": "Categorized and marked paid." "categorizedPaidToast": "Categorized and marked paid.",
"pendingRebill": "Pending re-bill",
"pendingTitle": "Pending re-bills",
"pendingBody": "Categorized invoices waiting to be re-billed. Bundle a clients items into one invoice.",
"pendingCount": "{{count}} item",
"pendingCount_other": "{{count}} items",
"billPending": "Bill these",
"bundledToast": "Bundled {{count}} re-bill into one invoice.",
"bundledToast_other": "Bundled {{count}} re-bills into one invoice."
}, },
"expense": { "expense": {
"kind": "Type", "kind": "Type",
@@ -6,10 +6,11 @@
* client. PDFs are previewed as server-rasterised page images (never raw). * client. PDFs are previewed as server-rasterised page images (never raw).
*/ */
import React, { useRef, useState, useEffect } from 'react'; import React, { useRef, useState, useEffect } from 'react';
import { useNavigate } from 'react-router-dom';
import { useQuery, useMutation, useQueryClient } from '@tanstack/react-query'; import { useQuery, useMutation, useQueryClient } from '@tanstack/react-query';
import { useTranslation } from 'react-i18next'; import { useTranslation } from 'react-i18next';
import { toast } from 'react-toastify'; import { toast } from 'react-toastify';
import { Camera, Upload, Inbox, X, Circle, Eye, RotateCcw } from 'lucide-react'; import { Camera, Upload, Inbox, X, Circle, Eye, RotateCcw, Send, Pencil } from 'lucide-react';
import { Button, Card, CardContent, Input, LocalizedDateInput, Loading } from '../../../components/common'; import { Button, Card, CardContent, Input, LocalizedDateInput, Loading } from '../../../components/common';
import { DecimalInput } from '../../../components/common/DecimalInput'; import { DecimalInput } from '../../../components/common/DecimalInput';
import { CustomerAccountPicker, type SelectedCustomer } from '../../../components/admin/CustomerAccountPicker'; import { CustomerAccountPicker, type SelectedCustomer } from '../../../components/admin/CustomerAccountPicker';
@@ -150,10 +151,14 @@ const ViewModal: React.FC<{ doc: InboundDocument; onClose: () => void }> = ({ do
{field(t('accounting.inbox.field.total', 'Total'), doc.totalAmountMinor != null ? formatMoneyMinor(doc.totalAmountMinor, doc.currency || 'CHF') : null)} {field(t('accounting.inbox.field.total', 'Total'), doc.totalAmountMinor != null ? formatMoneyMinor(doc.totalAmountMinor, doc.currency || 'CHF') : null)}
{field(t('accounting.inbox.field.invoiceDate', 'Invoice date'), doc.invoiceDate ? format(doc.invoiceDate) : null)} {field(t('accounting.inbox.field.invoiceDate', 'Invoice date'), doc.invoiceDate ? format(doc.invoiceDate) : null)}
{field(t('accounting.inbox.field.disposition', 'Disposition'), doc.disposition ? t(`accounting.disposition.${doc.disposition}`, doc.disposition) : null)} {field(t('accounting.inbox.field.disposition', 'Disposition'), doc.disposition ? t(`accounting.disposition.${doc.disposition}`, doc.disposition) : null)}
{field(t('accounting.inbox.status.label', 'Status'), t(`accounting.inbox.status.${doc.status}`, doc.status))} {doc.customerName && field(t('accounting.inbox.field.customer', 'Client'), doc.customerName)}
{field(t('accounting.inbox.status.label', 'Status'), doc.customerAccountId && !doc.billedInvoiceId
? t('accounting.incoming.pendingRebill', 'Pending re-bill')
: t(`accounting.inbox.status.${doc.status}`, doc.status))}
{field(t('accounting.incoming.paid', 'Paid'), doc.supplierPaid {field(t('accounting.incoming.paid', 'Paid'), doc.supplierPaid
? (doc.supplierPaidAt ? format(doc.supplierPaidAt) : t('common.yes', 'Yes')) ? (doc.supplierPaidAt ? format(doc.supplierPaidAt) : t('common.yes', 'Yes'))
: t('common.no', 'No'))} : t('common.no', 'No'))}
{doc.note && field(t('accounting.inbox.field.note', 'Note'), doc.note)}
</div> </div>
</div> </div>
<div className="flex justify-end gap-2 border-t border-neutral-200 dark:border-neutral-700 px-5 py-3"> <div className="flex justify-end gap-2 border-t border-neutral-200 dark:border-neutral-700 px-5 py-3">
@@ -171,12 +176,21 @@ const TriageModal: React.FC<{ doc: InboundDocument; categories: ExpenseCategory[
const [currency, setCurrency] = useState(doc.currency || 'CHF'); const [currency, setCurrency] = useState(doc.currency || 'CHF');
const [invoiceDate, setInvoiceDate] = useState(doc.invoiceDate || ''); const [invoiceDate, setInvoiceDate] = useState(doc.invoiceDate || '');
const [reference, setReference] = useState(doc.paymentReference || ''); const [reference, setReference] = useState(doc.paymentReference || '');
const [disposition, setDisposition] = useState<Disposition>('eigener_aufwand'); const [note, setNote] = useState(doc.note || '');
const [categoryId, setCategoryId] = useState<number | undefined>(undefined); // Pre-fill from the existing disposition so a categorized invoice can be
const [eventId, setEventId] = useState<number | null>(null); // re-categorized (#1) — falls back to "company expense" for fresh docs.
const [customer, setCustomer] = useState<SelectedCustomer[]>([]); const [disposition, setDisposition] = useState<Disposition>(doc.disposition || 'eigener_aufwand');
const [markupType, setMarkupType] = useState<MarkupType>('none'); const [categoryId, setCategoryId] = useState<number | undefined>(doc.categoryId ?? undefined);
const [markupValue, setMarkupValue] = useState<number>(NaN); const [eventId, setEventId] = useState<number | null>(doc.eventId ?? null);
const [customer, setCustomer] = useState<SelectedCustomer[]>(
doc.customerAccountId ? [{ id: doc.customerAccountId, email: doc.customerEmail || '', displayName: doc.customerName }] : [],
);
const [markupType, setMarkupType] = useState<MarkupType>(doc.markupType || 'none');
const [markupValue, setMarkupValue] = useState<number>(
doc.markupType === 'percent' && doc.markupPercent != null ? doc.markupPercent
: doc.markupType === 'flat' && doc.markupFlatMinor != null ? doc.markupFlatMinor / 100
: NaN,
);
const totalMinor = Number.isFinite(amountMajor) ? Math.round(amountMajor * 100) : null; const totalMinor = Number.isFinite(amountMajor) ? Math.round(amountMajor * 100) : null;
@@ -191,12 +205,13 @@ const TriageModal: React.FC<{ doc: InboundDocument; categories: ExpenseCategory[
// entered) — no second dialog — so "Save & mark paid" actually pays. // entered) — no second dialog — so "Save & mark paid" actually pays.
const save = useMutation({ const save = useMutation({
mutationFn: async (pay: boolean) => { mutationFn: async (pay: boolean) => {
await accountingService.updateInbound(doc.id, { supplierName: supplier || null, totalAmountMinor: totalMinor, currency: currency || null, invoiceDate: invoiceDate || null, paymentReference: reference || null }); await accountingService.updateInbound(doc.id, { supplierName: supplier || null, totalAmountMinor: totalMinor, currency: currency || null, invoiceDate: invoiceDate || null, paymentReference: reference || null, note: note || null });
await accountingService.categorizeInbound(doc.id, { await accountingService.categorizeInbound(doc.id, {
disposition, disposition,
eventId: BOOKING_DISPOSITIONS.includes(disposition) ? eventId : null, eventId: BOOKING_DISPOSITIONS.includes(disposition) ? eventId : null,
categoryId: disposition === 'eigener_aufwand' ? (categoryId ?? null) : null, categoryId: disposition === 'eigener_aufwand' ? (categoryId ?? null) : null,
customerAccountId: disposition === 'rebill' && customer[0] ? customer[0].id : null, // Both rebill and passthrough can attach to a customer (#3).
customerAccountId: BOOKING_DISPOSITIONS.includes(disposition) && customer[0] ? customer[0].id : null,
...markupPayload(), ...markupPayload(),
}); });
if (pay) { if (pay) {
@@ -229,6 +244,8 @@ const TriageModal: React.FC<{ doc: InboundDocument; categories: ExpenseCategory[
<div><label className={labelCls}>{t('accounting.inbox.field.currency', 'Currency')}</label><Input value={currency} maxLength={3} onChange={(e) => setCurrency(e.target.value.toUpperCase())} /></div> <div><label className={labelCls}>{t('accounting.inbox.field.currency', 'Currency')}</label><Input value={currency} maxLength={3} onChange={(e) => setCurrency(e.target.value.toUpperCase())} /></div>
<div className="col-span-2"><label className={labelCls}>{t('accounting.inbox.field.invoiceDate', 'Invoice date')}</label><LocalizedDateInput value={invoiceDate} onChange={setInvoiceDate} /></div> <div className="col-span-2"><label className={labelCls}>{t('accounting.inbox.field.invoiceDate', 'Invoice date')}</label><LocalizedDateInput value={invoiceDate} onChange={setInvoiceDate} /></div>
<div className="col-span-2"><label className={labelCls}>{t('accounting.inbox.field.reference', 'Payment reference')}</label><Input value={reference} onChange={(e) => setReference(e.target.value)} placeholder={t('accounting.inbox.field.referenceHint', 'QR / ESR reference or message') as string} /></div> <div className="col-span-2"><label className={labelCls}>{t('accounting.inbox.field.reference', 'Payment reference')}</label><Input value={reference} onChange={(e) => setReference(e.target.value)} placeholder={t('accounting.inbox.field.referenceHint', 'QR / ESR reference or message') as string} /></div>
<div className="col-span-2"><label className={labelCls}>{t('accounting.inbox.field.note', 'Note')}</label>
<textarea value={note} onChange={(e) => setNote(e.target.value)} rows={2} className={selectCls} placeholder={t('accounting.inbox.field.noteHint', 'Internal note for this invoice (optional)') as string} /></div>
</div> </div>
<div><label className={labelCls}>{t('accounting.inbox.field.disposition', 'Disposition')}</label> <div><label className={labelCls}>{t('accounting.inbox.field.disposition', 'Disposition')}</label>
@@ -253,10 +270,12 @@ const TriageModal: React.FC<{ doc: InboundDocument; categories: ExpenseCategory[
</div> </div>
)} )}
{disposition === 'rebill' && ( {BOOKING_DISPOSITIONS.includes(disposition) && (
<div className="space-y-3 rounded-lg border border-neutral-200 dark:border-neutral-700 p-3"> <div className="space-y-3 rounded-lg border border-neutral-200 dark:border-neutral-700 p-3">
<div><label className={labelCls}>{t('accounting.inbox.field.customer', 'Client')} *</label> <div><label className={labelCls}>{t('accounting.inbox.field.customer', 'Client')} {disposition === 'rebill' ? '*' : ''}</label>
<CustomerAccountPicker value={customer.slice(0, 1)} onChange={(next) => setCustomer(next.slice(-1))} /></div> <CustomerAccountPicker value={customer.slice(0, 1)} onChange={(next) => setCustomer(next.slice(-1))} />
{disposition === 'durchlaufend' && <p className="mt-1 text-xs text-neutral-500 dark:text-neutral-400">{t('accounting.inbox.field.passthroughCustomerHint', 'Optional — attach a client to re-bill this passthrough; leave empty to only book it to the event.')}</p>}
</div>
<div><label className={labelCls}>{t('accounting.inbox.field.markup', 'Markup')}</label> <div><label className={labelCls}>{t('accounting.inbox.field.markup', 'Markup')}</label>
<select value={markupType} onChange={(e) => setMarkupType(e.target.value as MarkupType)} className={selectCls}> <select value={markupType} onChange={(e) => setMarkupType(e.target.value as MarkupType)} className={selectCls}>
<option value="none">{t('accounting.markup.none', 'None / from contract')}</option> <option value="none">{t('accounting.markup.none', 'None / from contract')}</option>
@@ -283,6 +302,7 @@ const TriageModal: React.FC<{ doc: InboundDocument; categories: ExpenseCategory[
export const AccountingInboxPage: React.FC = () => { export const AccountingInboxPage: React.FC = () => {
const { t } = useTranslation(); const { t } = useTranslation();
const qc = useQueryClient(); const qc = useQueryClient();
const navigate = useNavigate();
const { format } = useLocalizedDate(); const { format } = useLocalizedDate();
const cameraRef = useRef<HTMLInputElement>(null); const cameraRef = useRef<HTMLInputElement>(null);
const uploadRef = useRef<HTMLInputElement>(null); const uploadRef = useRef<HTMLInputElement>(null);
@@ -294,6 +314,8 @@ export const AccountingInboxPage: React.FC = () => {
// without a manual reload (the poller runs server-side every 60s). // without a manual reload (the poller runs server-side every 60s).
const { data, isLoading } = useQuery({ queryKey: ['accounting-inbound'], queryFn: () => accountingService.listInbound({ pageSize: 100 }), refetchInterval: 30000, refetchOnWindowFocus: true }); const { data, isLoading } = useQuery({ queryKey: ['accounting-inbound'], queryFn: () => accountingService.listInbound({ pageSize: 100 }), refetchInterval: 30000, refetchOnWindowFocus: true });
const { data: categories } = useQuery({ queryKey: ['expense-categories'], queryFn: () => accountingService.listCategories() }); const { data: categories } = useQuery({ queryKey: ['expense-categories'], queryFn: () => accountingService.listCategories() });
// Per-event customers carrying pending (categorised, unbilled) re-bills (#3).
const { data: pending } = useQuery({ queryKey: ['accounting-pending-rebills'], queryFn: () => accountingService.listPendingRebills(), refetchInterval: 30000 });
const upload = useMutation({ const upload = useMutation({
mutationFn: ({ file, source }: { file: File; source: 'upload' | 'camera' }) => accountingService.uploadInbound(file, source), mutationFn: ({ file, source }: { file: File; source: 'upload' | 'camera' }) => accountingService.uploadInbound(file, source),
@@ -305,11 +327,24 @@ export const AccountingInboxPage: React.FC = () => {
onSuccess: () => { qc.invalidateQueries({ queryKey: ['accounting-inbound'] }); }, onSuccess: () => { qc.invalidateQueries({ queryKey: ['accounting-inbound'] }); },
onError: (e: any) => toast.error(e?.response?.data?.error || e.message || 'Failed'), onError: (e: any) => toast.error(e?.response?.data?.error || e.message || 'Failed'),
}); });
const billPending = useMutation({
mutationFn: (customerAccountId: number) => accountingService.billPendingRebills(customerAccountId),
onSuccess: ({ invoiceId, count }) => {
toast.success(t('accounting.incoming.bundledToast', 'Bundled {{count}} re-bill(s) into one invoice.', { count }));
qc.invalidateQueries({ queryKey: ['accounting-inbound'] });
qc.invalidateQueries({ queryKey: ['accounting-pending-rebills'] });
navigate(`/admin/clients/bills/${invoiceId}/edit`);
},
onError: (e: any) => toast.error(e?.response?.data?.error || e.message || 'Failed'),
});
const onFile = (source: 'upload' | 'camera') => (e: React.ChangeEvent<HTMLInputElement>) => { const onFile = (source: 'upload' | 'camera') => (e: React.ChangeEvent<HTMLInputElement>) => {
const file = e.target.files?.[0]; if (file) upload.mutate({ file, source }); e.target.value = ''; const file = e.target.files?.[0]; if (file) upload.mutate({ file, source }); e.target.value = '';
}; };
const refresh = () => qc.invalidateQueries({ queryKey: ['accounting-inbound'] }); const refresh = () => { qc.invalidateQueries({ queryKey: ['accounting-inbound'] }); qc.invalidateQueries({ queryKey: ['accounting-pending-rebills'] }); };
const pendingItems = pending ?? [];
const customerLabel = (p: typeof pendingItems[number]) => p.displayName || p.companyName || [p.firstName, p.lastName].filter(Boolean).join(' ') || p.email || `#${p.customerAccountId}`;
const handleTriageDone = () => { setTriageDoc(null); refresh(); }; const handleTriageDone = () => { setTriageDoc(null); refresh(); };
@@ -329,6 +364,31 @@ export const AccountingInboxPage: React.FC = () => {
<Button variant="outline" onClick={() => uploadRef.current?.click()} disabled={upload.isPending}><Upload className="w-4 h-4 mr-2" /> {t('accounting.inbox.uploadFile', 'Upload file')}</Button> <Button variant="outline" onClick={() => uploadRef.current?.click()} disabled={upload.isPending}><Upload className="w-4 h-4 mr-2" /> {t('accounting.inbox.uploadFile', 'Upload file')}</Button>
</CardContent></Card> </CardContent></Card>
{/* Pending re-bills (#3): per-event customers accumulate categorised
rebill/passthrough invoices here; bundle them into one invoice like
"Bill these hours". Monthly/manual customers never surface (they
consolidate onto their running draft at categorise time). */}
{pendingItems.length > 0 && (
<Card className="mb-6"><CardContent className="p-5">
<h2 className="text-base font-semibold text-neutral-900 dark:text-neutral-100 mb-1">{t('accounting.incoming.pendingTitle', 'Pending re-bills')}</h2>
<p className="text-sm text-neutral-600 dark:text-neutral-400 mb-3">{t('accounting.incoming.pendingBody', 'Categorized invoices waiting to be re-billed. Bundle a clients items into one invoice.')}</p>
<div className="space-y-2">
{pendingItems.map((p) => (
<div key={p.customerAccountId} className="flex flex-wrap items-center gap-3 rounded-lg border border-neutral-200 dark:border-neutral-700 px-4 py-2">
<div className="flex-1 min-w-[12rem]">
<div className="text-sm font-medium text-neutral-900 dark:text-neutral-100">{customerLabel(p)}</div>
<div className="text-xs text-neutral-500 dark:text-neutral-400">
{t('accounting.incoming.pendingCount', '{{count}} item(s)', { count: p.itemCount })}
{' · '}{formatMoneyMinor(p.openAmountMinor, 'CHF')}
</div>
</div>
<Button size="sm" onClick={() => billPending.mutate(p.customerAccountId)} disabled={billPending.isPending}><Send className="w-3.5 h-3.5 mr-1" /> {t('accounting.incoming.billPending', 'Bill these')}</Button>
</div>
))}
</div>
</CardContent></Card>
)}
{isLoading ? <Loading /> : items.length === 0 ? ( {isLoading ? <Loading /> : items.length === 0 ? (
<div className="rounded-xl border border-dashed border-neutral-300 dark:border-neutral-700 bg-neutral-50 dark:bg-neutral-900 p-8 text-center"> <div className="rounded-xl border border-dashed border-neutral-300 dark:border-neutral-700 bg-neutral-50 dark:bg-neutral-900 p-8 text-center">
<Inbox className="w-10 h-10 mx-auto mb-3 text-neutral-400" /> <Inbox className="w-10 h-10 mx-auto mb-3 text-neutral-400" />
@@ -362,6 +422,10 @@ export const AccountingInboxPage: React.FC = () => {
{doc.totalAmountMinor != null ? formatMoneyMinor(doc.totalAmountMinor, doc.currency || 'CHF') : t('accounting.inbox.noAmount', 'amount not entered')} {doc.totalAmountMinor != null ? formatMoneyMinor(doc.totalAmountMinor, doc.currency || 'CHF') : t('accounting.inbox.noAmount', 'amount not entered')}
{' · '}{format(doc.createdAt)} {' · '}{format(doc.createdAt)}
{doc.disposition && <>{' · '}{t(`accounting.disposition.${doc.disposition}`, doc.disposition)}</>} {doc.disposition && <>{' · '}{t(`accounting.disposition.${doc.disposition}`, doc.disposition)}</>}
{/* Pending re-bill = attached to a client but not yet on an invoice. */}
{doc.customerAccountId && !doc.billedInvoiceId && (
<span className="text-indigo-600 dark:text-indigo-400">{' · '}{t('accounting.incoming.pendingRebill', 'Pending re-bill')}{doc.customerName ? `${doc.customerName}` : ''}</span>
)}
</div> </div>
</button> </button>
<Button size="sm" variant="ghost" onClick={() => setViewDoc(doc)}><Eye className="w-3.5 h-3.5 mr-1" /> {t('accounting.inbox.view', 'View')}</Button> <Button size="sm" variant="ghost" onClick={() => setViewDoc(doc)}><Eye className="w-3.5 h-3.5 mr-1" /> {t('accounting.inbox.view', 'View')}</Button>
@@ -372,7 +436,11 @@ export const AccountingInboxPage: React.FC = () => {
? <Button size="sm" variant="ghost" onClick={() => unpay.mutate(doc.id)} disabled={unpay.isPending}><RotateCcw className="w-3.5 h-3.5 mr-1" /> {t('accounting.incoming.markUnpaid', 'Mark unpaid')}</Button> ? <Button size="sm" variant="ghost" onClick={() => unpay.mutate(doc.id)} disabled={unpay.isPending}><RotateCcw className="w-3.5 h-3.5 mr-1" /> {t('accounting.incoming.markUnpaid', 'Mark unpaid')}</Button>
: <Button size="sm" variant="outline" onClick={() => setPayDoc(doc)}><Circle className="w-3.5 h-3.5 mr-1" /> {t('accounting.incoming.markPaid', 'Mark paid')}</Button> : <Button size="sm" variant="outline" onClick={() => setPayDoc(doc)}><Circle className="w-3.5 h-3.5 mr-1" /> {t('accounting.incoming.markPaid', 'Mark paid')}</Button>
)} )}
{doc.status === 'unsorted' && <Button size="sm" onClick={() => setTriageDoc(doc)}>{t('accounting.inbox.categorize', 'Categorize')}</Button>} {/* #1: re-categorize is available after the first triage too, so a
disposition can be changed (e.g. passthrough → company expense). */}
{doc.status === 'unsorted'
? <Button size="sm" onClick={() => setTriageDoc(doc)}>{t('accounting.inbox.categorize', 'Categorize')}</Button>
: <Button size="sm" variant="outline" onClick={() => setTriageDoc(doc)}><Pencil className="w-3.5 h-3.5 mr-1" /> {t('accounting.inbox.recategorize', 'Re-categorize')}</Button>}
</div> </div>
))} ))}
</div> </div>
@@ -35,6 +35,12 @@ export interface InboundDocument {
markupPercent: number | null; markupPercent: number | null;
markupFlatMinor: number | null; markupFlatMinor: number | null;
billedInvoiceId: number | null; billedInvoiceId: number | null;
/** Client a rebill/passthrough is attached to (migration 132). */
customerAccountId: number | null;
customerName: string | null;
customerEmail: string | null;
/** Free-text categorisation note. */
note: string | null;
supplierPaid: boolean; supplierPaid: boolean;
supplierPaidAt: string | null; supplierPaidAt: string | null;
supplierPaymentMethod: PaymentMethod | null; supplierPaymentMethod: PaymentMethod | null;
@@ -79,6 +85,20 @@ export interface InvoiceExpensePayload {
markupFlatMinor?: number | null; markupFlatMinor?: number | null;
} }
/** One customer with categorised-but-unbilled rebill/passthrough docs. */
export interface PendingRebillSummary {
customerAccountId: number;
companyName: string | null;
displayName: string | null;
firstName: string | null;
lastName: string | null;
email: string | null;
isPassive: boolean;
billingCadence: string | null;
itemCount: number;
openAmountMinor: number;
}
export interface ExpenseCategory { id: number; name: string; color: string | null; is_seed: boolean; display_order: number; } export interface ExpenseCategory { id: number; name: string; color: string | null; is_seed: boolean; display_order: number; }
export interface Paginated<T> { items: T[]; pagination: { page: number; pageSize: number; total: number; totalPages: number }; } export interface Paginated<T> { items: T[]; pagination: { page: number; pageSize: number; total: number; totalPages: number }; }
@@ -148,6 +168,10 @@ export const accountingService = {
async updateInbound(id: number, fields: Partial<InboundDocument>): Promise<InboundDocument> { const { data } = await api.patch(`/admin/expenses/inbound/${id}`, fields); return data.document; }, async updateInbound(id: number, fields: Partial<InboundDocument>): Promise<InboundDocument> { const { data } = await api.patch(`/admin/expenses/inbound/${id}`, fields); return data.document; },
async categorizeInbound(id: number, payload: CategorizePayload): Promise<InboundDocument> { const { data } = await api.post(`/admin/expenses/inbound/${id}/categorize`, payload); return data.document; }, async categorizeInbound(id: number, payload: CategorizePayload): Promise<InboundDocument> { const { data } = await api.post(`/admin/expenses/inbound/${id}/categorize`, payload); return data.document; },
async rebillInbound(id: number, payload: CategorizePayload): Promise<{ document: InboundDocument; invoiceId: number }> { const { data } = await api.post(`/admin/expenses/inbound/${id}/rebill`, payload); return data; }, async rebillInbound(id: number, payload: CategorizePayload): Promise<{ document: InboundDocument; invoiceId: number }> { const { data } = await api.post(`/admin/expenses/inbound/${id}/rebill`, payload); return data; },
/** Per-event customers with pending (categorised, unbilled) re-bills. */
async listPendingRebills(): Promise<PendingRebillSummary[]> { const { data } = await api.get('/admin/expenses/inbound/pending-summary'); return data.items; },
/** Bundle one customer's pending re-bills into a single invoice. */
async billPendingRebills(customerAccountId: number): Promise<{ invoiceId: number; count: number }> { const { data } = await api.post('/admin/expenses/inbound/bill-pending', { customerAccountId }); return data; },
async markInboundPaid(id: number, payload: { paid: boolean; paidAt?: string; paymentMethod?: PaymentMethod; paymentReference?: string }): Promise<InboundDocument> { const { data } = await api.post(`/admin/expenses/inbound/${id}/supplier-payment`, payload); return data.document; }, async markInboundPaid(id: number, payload: { paid: boolean; paidAt?: string; paymentMethod?: PaymentMethod; paymentReference?: string }): Promise<InboundDocument> { const { data } = await api.post(`/admin/expenses/inbound/${id}/supplier-payment`, payload); return data.document; },
async getInboundFileBlob(id: number): Promise<Blob> { const { data } = await api.get(`/admin/expenses/inbound/${id}/file`, { responseType: 'blob' }); return data; }, async getInboundFileBlob(id: number): Promise<Blob> { const { data } = await api.get(`/admin/expenses/inbound/${id}/file`, { responseType: 'blob' }); return data; },
async getInboundPageBlob(id: number, page: number): Promise<Blob> { const { data } = await api.get(`/admin/expenses/inbound/${id}/page/${page}`, { responseType: 'blob' }); return data; }, async getInboundPageBlob(id: number, page: number): Promise<Blob> { const { data } = await api.get(`/admin/expenses/inbound/${id}/page/${page}`, { responseType: 'blob' }); return data; },