paul/picpeak
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(slideshow): stop "no crop" fit letterboxing a pre-cropped frame (stable) (#1015) (#1019)

Browse Source 
Backport of #1018 to the curated channel; the reporter on #1015 is running v3.45.14.

The slideshow resolved its image as preview_url || hero_url || url. preview_url is only emitted when lightbox_preview_enabled is on (default false), so a default install fell through to hero_url — the 1920x1080 fit:'cover' centre crop built for gallery header banners. object-fit: contain then letterboxed an already-cropped 16:9 frame.

Emits slideshow_url (same aspect-preserved preview tier) unconditionally for image photos; the show prefers it and never falls back to hero_url. preview_url stays gated so the lightbox opt-in is unchanged.
This commit is contained in:
Paul Nothaft
2026-08-10 13:32:24 +02:00
committed by GitHub
parent cee0a380a6
commit 2bdb1204fe
4 changed files with 174 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/pages/gallery/SlideshowPage.tsx
+8 -1
View File
@@ -23,8 +23,15 @@ const STATE_POLL_MS = 3000;
// Prefer the aspect-preserved preview (≤1920px) over the full original; fall
// back to the standard url. Always absolutised so it works whether the API is
// same-origin or an explicit absolute base.
//
// Deliberately never `hero_url` (#1015): that tier is cover-cropped to 16:9
// for gallery header banners, so with fit='contain' the show letterboxed an
// already-cropped frame — portrait photos lost their top and bottom and the
// "Black Bars (No crop)" setting looked broken. `slideshow_url` is the same
// aspect-preserved preview as `preview_url` but is always emitted, so the
// crop can't come back when lightbox previews are off (the default).
function photoSrc(photo: Photo): string {
return buildResourceUrl(photo.preview_url || photo.hero_url || photo.url);
return buildResourceUrl(photo.slideshow_url || photo.preview_url || photo.url);
}
// CSS `filter` applied directly to the image for filters that are pure tone
frontend/src/types/index.ts
+5
View File
@@ -116,6 +116,11 @@ export interface Photo {
// ≤1920px JPEG; the lightbox prefers it over `url` for image photos
// and falls back to `url` when null (off, video, or not yet generated).
preview_url?: string | null;
// Aspect-preserved ≤1920px source for the fullscreen slideshow (#1015).
// Always set for image photos, unlike `preview_url` — the slideshow must
// never fall back to `hero_url`, which is a 16:9 centre crop and makes
// the "Black Bars (No crop)" fit letterbox an already-cropped frame.
slideshow_url?: string | null;
secure_url_template?: string;
download_url_template?: string;
requires_token?: boolean;