paul/picpeak
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(slideshow): drop updated_at from event writes

Browse Source 
The events table has no updated_at column (only created_at, and no migration
adds one), so the slideshow generate/disable/settings endpoints 500'd with
'column "updated_at" does not exist'. Write only the show_* columns, and guard
the settings PATCH against an empty update.
This commit is contained in:
Luca
2026-06-20 01:49:30 +02:00
parent cb761ee621
commit 1e40f8296c
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/routes/adminEvents.js
+10 -6
View File
@@ -1944,9 +1944,10 @@ router.post('/:id/slideshow/generate', adminAuth, requirePermission('events.edit
} }
const token = crypto.randomBytes(32).toString('hex'); const token = crypto.randomBytes(32).toString('hex');
// NB: the events table has no updated_at column (only created_at), so we
// must not set it here or the UPDATE throws.
await db('events').where('id', req.params.id).update({ await db('events').where('id', req.params.id).update({
show_share_token: token, show_share_token: token
updated_at: new Date()
}); });
await logActivity('slideshow_link_generated', await logActivity('slideshow_link_generated',
@@ -1975,8 +1976,7 @@ router.post('/:id/slideshow/disable', adminAuth, requirePermission('events.edit'
} }
await db('events').where('id', req.params.id).update({ await db('events').where('id', req.params.id).update({
show_share_token: null, show_share_token: null
updated_at: new Date()
}); });
await logActivity('slideshow_link_disabled', await logActivity('slideshow_link_disabled',
@@ -2017,7 +2017,8 @@ router.patch('/:id/slideshow', adminAuth, requirePermission('events.edit'), requ
return res.status(404).json({ error: 'Event not found' }); return res.status(404).json({ error: 'Event not found' });
} }
const updates = { updated_at: new Date() }; // events has no updated_at column — don't set it.
const updates = {};
if (req.body.show_interval_ms !== undefined) updates.show_interval_ms = parseInt(req.body.show_interval_ms, 10); if (req.body.show_interval_ms !== undefined) updates.show_interval_ms = parseInt(req.body.show_interval_ms, 10);
if (req.body.show_transition !== undefined) updates.show_transition = req.body.show_transition; if (req.body.show_transition !== undefined) updates.show_transition = req.body.show_transition;
if (req.body.show_transition_ms !== undefined) updates.show_transition_ms = parseInt(req.body.show_transition_ms, 10); if (req.body.show_transition_ms !== undefined) updates.show_transition_ms = parseInt(req.body.show_transition_ms, 10);
@@ -2033,7 +2034,10 @@ router.patch('/:id/slideshow', adminAuth, requirePermission('events.edit'), requ
if (req.body.show_watermark_style !== undefined) updates.show_watermark_style = req.body.show_watermark_style; if (req.body.show_watermark_style !== undefined) updates.show_watermark_style = req.body.show_watermark_style;
if (req.body.show_colorfilter !== undefined) updates.show_colorfilter = req.body.show_colorfilter; if (req.body.show_colorfilter !== undefined) updates.show_colorfilter = req.body.show_colorfilter;
await db('events').where('id', req.params.id).update(updates); // Knex throws on an empty update; only write if something changed.
if (Object.keys(updates).length > 0) {
await db('events').where('id', req.params.id).update(updates);
}
res.json({ res.json({
show_interval_ms: updates.show_interval_ms ?? event.show_interval_ms ?? 5000, show_interval_ms: updates.show_interval_ms ?? event.show_interval_ms ?? 5000,