paul/picpeak
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: handle legacy non-JSON logo paths when replacing logo

Browse Source 
When uploading a new logo, the code tries to delete the old logo file.
This failed when the old path was stored as a raw path (legacy format)
instead of JSON-serialized. Added check to handle both formats.
This commit is contained in:
Paul Nothaft
2026-01-08 11:44:29 +01:00
parent 4872ef71f8
commit 0d5ce48dcc
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/routes/adminSettings.js
+5 -1
View File
@@ -326,8 +326,12 @@ router.post('/logo', adminAuth, requirePermission('settings.edit'), upload.singl
.first(); .first();
if (oldLogoSetting && oldLogoSetting.setting_value) { if (oldLogoSetting && oldLogoSetting.setting_value) {
const oldPath = JSON.parse(oldLogoSetting.setting_value);
try { try {
// Handle both JSON-serialized and legacy raw path values
let oldPath = oldLogoSetting.setting_value;
if (oldPath.startsWith('"')) {
oldPath = JSON.parse(oldPath);
}
await fs.unlink(oldPath); await fs.unlink(oldPath);
} catch (error) { } catch (error) {
console.error('Failed to delete old logo:', error); console.error('Failed to delete old logo:', error);