paul/picpeak
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

test(e2e): anchor the admin login button locator so SSO doesn't break it (#1012)

Browse Source 
With OIDC enabled the login page also renders a 'Sign in with <provider>' button whose accessible name matches the unanchored /Sign In/ locator, so Playwright strict mode failed every test that logs in — 7 of 13 in the local smoke suite, which is also the pre-push gate. CI never hit it because its databases seed without OIDC config.

Anchors the regex to the full accessible name in all six call sites.
This commit is contained in:
Paul Nothaft
2026-08-10 09:53:18 +02:00
committed by GitHub
parent 5503e6ca5e
commit 03671f3b91
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/seo-settings.spec.ts
+1 -1
View File
@@ -8,7 +8,7 @@ async function loginAndGoToSeoSettings(page) {
await page.goto('/admin/login');
await page.getByLabel(/Email|E-Mail/i).fill(ADMIN_EMAIL);
await page.getByLabel(/Password|Passwort/i).fill(ADMIN_PASSWORD);
await page.getByRole('button', { name: /Sign In|Log in|Anmelden/i }).click();
await page.getByRole('button', { name: /^(Sign In|Log in|Anmelden)$/i }).click();
await expect(page.getByRole('heading', { name: /Dashboard|Übersicht/i })).toBeVisible({ timeout: 20000 });
await page.goto('/admin/settings');